Ticket #9619 (closed: fixed)
FindQwt can sometimes report an incorrect version
Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.3 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Peter Peterson |
Description
Opened for a pull request
Change History
comment:2 Changed 6 years ago by Nick Draper
- Milestone changed from Release 3.2 to Backlog
Moved to Backlog at the code freeze of release 3.2
comment:3 Changed 6 years ago by Joachim Wuttke (o)
- Status changed from assigned to inprogress
Revise FindQwt.cmake.
Revise FindQwt.cmake to fix the following:
- in case of error, don't set version="0.0.0" to provoke upstream fatal error, but exit immediately with clear error message;
- search qwt.h in all possible combinations of include paths and qwt subdirectory names, using CMake's PATH_SUFFIXES parameter;
- try versioned directory and library names first.
refs #9619
Changeset: 40245b6ec33a8c46c3a0a553593fe31a3eccfcee
comment:4 Changed 6 years ago by Joachim Wuttke (o)
Revise FindQwt.cmake.
Revise FindQwt.cmake to fix the following:
- in case of error, don't set version="0.0.0" to provoke upstream fatal error, but exit immediately with clear error message;
- search qwt.h in all possible combinations of include paths and qwt subdirectory names, using CMake's PATH_SUFFIXES parameter;
- try versioned directory and library names first.
refs #9619
Changeset: 40245b6ec33a8c46c3a0a553593fe31a3eccfcee
comment:5 Changed 6 years ago by Martyn Gigg
- Status changed from inprogress to verify
- Resolution set to fixed
Branch: bugfix/9619_fix_findqwt_error_report
Tester: The changes here make FindQwt exit with a better message when not finding the Qwt libraries. Have a look at the changes and ensure that all clean develop builds are passing.
comment:7 Changed 6 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:8 Changed 6 years ago by Pete Peterson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/9619_fix_findqwt_error_report'
Full changeset: 6ef9ef9ad4a6a58f086986ff0b85ad39706e91a5