Ticket #9645 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Mark SANSDirectBeamScaling as obsolete

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 3.2
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description


Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Nick Draper

Approved by Mathieu

comment:4 Changed 6 years ago by Nick Draper

I'm looking at documenting one of your algorithms SASNDirectBeamScaling

[11/06/2014 13:32:30] Nicholas Draper: Grepping the code base I can't find any use of the algorithm and we have now tests for this.

[11/06/2014 13:32:45] Nicholas Draper: Is this one dead? should it be removed?

[11/06/2014 16:19:36] Mathieu Doucet (ORNL): Hm. I think that's not used anywhere. Could we mark it as obsolete for the next release and phase it out (rather than just deleting it and realizing that someone has it in there script)?

comment:5 Changed 6 years ago by Nick Draper

re #9645 deprecate algorithm

Changeset: edf16adfc10403ef28ed270a06fa4a484ee0dbee

comment:6 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

to test:

  1. check you get a deprecation warning when running this algorithm

comment:7 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:8 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to verify
  • Tester Karl Palmen deleted

This needs to be tested by someone who knows how to obtain an input workspace with wavelength units.

A working usage example would have been useful.

comment:9 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

The usage example of AbsorptionCorrection ( #9638 ) has proven useful for this.

comment:10 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9645_deprecate_SANSDirectBeamScaling'

Full changeset: ​e1d00d7ba1fd8f4754b1866c1183300cb695e32b

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10488

Note: See TracTickets for help on using tickets.