Ticket #9665 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

IDA: Investigate bug in Apply Corrections scaling

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.2
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Parker

Description

Reported by Franz. There appears to be a bug in Apply Corrections with the can scale factor. It seems that it modifies the original reduced workspace (which we shouldn't do) by the scale factor.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned
  • Milestone changed from Backlog to Release 3.2

comment:2 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #9665 Scale a copy of the original workspace.

The original can run should remain unchanged.

Changeset: 0868a7805248260813c0664a1fde165463061472

comment:3 Changed 6 years ago by Samuel Jackson

Refs #9665 Swap to using scale_container var so we can delete it.

Changeset: 11f3930131146b7a7b0baf5cad322fec1cfa4ae1

comment:4 Changed 6 years ago by Samuel Jackson

To Test

First check you can reproduce:

  • Open the indirect data analysis window and select tab Apply Corrections
  • Open the file irs26176_graphite002_red.nxs as the sample (files in sys tests)
  • Open the file irs26173_graphite002_red.nxs as the can
  • Select Scale Can option, set factor to 0.5
  • Run
  • Plot irs26173_graphite002_red, you will notice it has been scaled by 0.5
  • Run again (same settings)
  • Plot irs26173_graphite002_red, you will notice is has been scaled again!

Then check the fix works:

  • Apply the changes
  • Follow the steps as above.
  • Note that the original workspace supplied as the container is not scaled.

comment:5 Changed 6 years ago by Samuel Jackson

Refs #9665 Fix bug with using can without scaling.

Changeset: a57d854b1ca6116e78baf461b16e6f23b8262d1e

comment:6 Changed 6 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:8 Changed 6 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9665_apply_corr_scaling_bug'

Full changeset: ​48e09505905cc5d524750a2cb0ca9af30f5aca5a

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10508

Note: See TracTickets for help on using tickets.