Ticket #967 (closed: fixed)
Instrument Parameter functions including simple formulas
Reported by: | Nick Draper | Owned by: | Anders Markvardsen |
---|---|---|---|
Priority: | critical | Milestone: | Iteration 22 |
Component: | Keywords: | ||
Cc: | Blocked By: | ||
Blocking: | Tester: |
Description (last modified by Nick Draper) (diff)
Target Date: 06/01/2010
Allow users to specify instrument level parameters (for things such as sigma in ikeda carpenter) as a function that can be evaluated when it is required. The user should be able to provide a single value or a function that will be used as a default value.
They should be able to enter the following:
- Function
- Parameter
- formula (accept a single value as well)
- Fixed (boolean default to false)
- Max (use as a bounded constraint if entered)
- Min (use as a bounded constraint if entered)
- PenaltyFactor (use as a bounded constraint if entered)
The steps involved here are (with estimates)
- define xml file format (2h)
- LoadInstrument Changes (8h)
- Calculate defaults for parameters in Function base class (8h)
- Muparser function evaulation (4h)
Change History
comment:1 Changed 11 years ago by Nick Draper
- Description modified (diff)
- Summary changed from Instrument Parameter functions including unit conversion to Instrument Parameter functions including simple formulas
comment:5 Changed 11 years ago by Anders Markvardsen
(In [3783]) Change <parameter> notation from
<parameter name="x" logfile-id="trolley2_x_displacement" extract-single-value-as="position 1" />
to
<parameter name="x"> <logfile id="trolley2_x_displacement" extract-single-value-as="position 1" /> </parameter>
and e.g.
<parameter name="x" value="7.2" />
to
<parameter name="x"> <value= val="7.2" /> </parameter>
Refs #967.
comment:11 Changed 11 years ago by Anders Markvardsen
comment:12 Changed 11 years ago by Anders Markvardsen
comment:13 Changed 11 years ago by Anders Markvardsen
comment:14 Changed 11 years ago by Anders Markvardsen
comment:15 Changed 11 years ago by Anders Markvardsen
comment:16 Changed 11 years ago by Anders Markvardsen
comment:17 Changed 11 years ago by Anders Markvardsen
(In [3976]) When specifying fitting parameter now can associate fitting parameter with fitting function using notation
<parameter name="IkedaCarpenterPV:Alpha0" type="fitting"> <value val="0.734079"/> <fixed /> </parameter>
where IkedaCarpenterPV is the function the parameter is associated with. Wiki not updated yet. Refs #967.
comment:18 Changed 11 years ago by Anders Markvardsen
(In [3984]) Updated http://www.mantidproject.org/InstrumentDefinitionFile in connection with previous commit to this ticket. Allow parameter to be specified at instrument level and done this for the GEM instrument. Added more tests. Refs #967.
comment:19 Changed 11 years ago by Anders Markvardsen
comment:20 Changed 11 years ago by Martyn Gigg
comment:21 Changed 11 years ago by Anders Markvardsen
comment:22 Changed 11 years ago by Anders Markvardsen
(In [4034]) The following look up table syntax now gets populated in the workspace parameter map
<parameter name="somefunction:toplevel2" type="fitting">
<lookuptable interpolation="linear" x-unit="TOF">
<point x="1" y="1" /> <point x="3" y="100" /> <point x="5" y="1120" /> <point x="10" y="1140" />
</lookuptable>
</parameter>
Refs #967.
comment:23 Changed 11 years ago by Anders Markvardsen
comment:24 Changed 11 years ago by Roman Tolchenov
comment:25 Changed 11 years ago by Anders Markvardsen
comment:26 Changed 11 years ago by Anders Markvardsen
comment:27 Changed 11 years ago by Anders Markvardsen
comment:28 Changed 11 years ago by Russell Taylor
comment:29 Changed 11 years ago by Anders Markvardsen
comment:30 Changed 11 years ago by Anders Markvardsen
comment:31 Changed 11 years ago by Anders Markvardsen
comment:32 Changed 11 years ago by Anders Markvardsen
comment:33 Changed 11 years ago by Anders Markvardsen
comment:34 Changed 11 years ago by Anders Markvardsen
(In [4143]) Allow the following percentage notation
<parameter name="somefunction:Alpha" type="fitting">
<value val="250.0" /> <min val="80%"/> <max val="120%"/>
</parameter>
results in Alpha being constrained to sit between 250*0.8=200 and 250*1.20=300.
Wiki http://www.mantidproject.org/InstrumentDefinitionFile updated.
Refs #967.
comment:35 Changed 11 years ago by Anders Markvardsen
comment:37 Changed 11 years ago by Anders Markvardsen
- Status changed from accepted to testing
- Resolution set to fixed
comment:38 Changed 11 years ago by Anders Markvardsen
- Status changed from testing to reopened
- Resolution fixed deleted
comment:39 Changed 11 years ago by Anders Markvardsen
comment:40 Changed 11 years ago by Anders Markvardsen
comment:41 Changed 11 years ago by Anders Markvardsen
- Status changed from reopened to testing
- Resolution set to fixed
comment:43 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 1815