Ticket #9688 (closed: fixed)
IndirectMoments should use AlgorithmRunner
Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Peter Parker |
Description (last modified by Samuel Jackson) (diff)
I didn't notice this on my machine due to the speed at which it executes, but on some slower machines, the execution time is noticeable.
Swap the interface to use the AlgorithmRunner class. While we're there we should also add a set rethrows call.
Change History
comment:3 Changed 6 years ago by Samuel Jackson
- Status changed from assigned to inprogress
Refs #9688 Swap to using AlgorithmRunner for SofQWMoments.
Changeset: a63ee3c13e89cc03c1e126c53ae0a569248abfe4
comment:4 Changed 6 years ago by Samuel Jackson
To Test
Not much to test. The moments tab on Indirect Convert to Energy should work exactly the same as it did before, but the algorithm now runs on a separate thread. I suggest routine to check it works and doing a code review.
comment:5 Changed 6 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:6 Changed 6 years ago by Peter Parker
- Status changed from verify to verifying
- Tester set to Peter Parker
comment:7 Changed 6 years ago by Peter Parker
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/9688_indirect_moments_alg_runner'
Full changeset: fd74eede941ac8c6ced70294a2b5b4dc16bd455e