Ticket #9691 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

MaskWorkspace refactoring

Reported by: Roman Tolchenov Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

m_hasInstrument doesn't get updated after an instrument is set (see for example DetectorDiagnostic::generateEmptyMask).

There are code duplications and different conditions are used for setting m_hasInstrument.

Can m_hasInstrument be replaced with calls to hasInstrument()?

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned
  • Owner set to Dan Nixon

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Removed m_hasInstrument, replaced with call to hasInstrument()

Refs #9691

Changeset: 27658a92b81c7796c923a74db6930fb4c30ccc6b

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:4 Changed 6 years ago by Dan Nixon

Have replaced all instances of m_hasInstrument with hasInstrument().

There was one instance where the logic defining m_hasInstrument differed from that of hasInstrument(), I have left a note marking this instance if it ever causes an issue.

Based on where it is used testing with hasInstrument() seems more correct.

comment:5 Changed 6 years ago by Peter Parker

  • Milestone changed from Backlog to Release 3.3

comment:6 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:7 Changed 6 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9691_maskworkspace_refactoring'

Full changeset: ​13f9f9d20a1c387bd646a49f4f53057256ad4ddf

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10533

Note: See TracTickets for help on using tickets.