Ticket #9711 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Refactor PoldiMerge to use MergeRuns

Reported by: Michael Wedel Owned by: Michael Wedel
Priority: major Milestone: Release 3.3
Component: Diffraction Keywords: POLDI
Cc: Blocked By:
Blocking: #10090 Tester: Roman Tolchenov

Description

In order to make use of the history preserving changes introduced to MergeRuns in #9548, PoldiMerge should be adjusted from using Plus to using MergeRuns.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Michael Wedel

  • Status changed from assigned to inprogress

Refs #9711. Refactored PoldiMerge to use MergeRuns

Consequently, WorkspaceGroups can be handled now as well.

Changeset: 4f837f2f9c9bbc43069bcd8c30b5c32955b9d8a3

comment:3 Changed 6 years ago by Michael Wedel

Refs #9711. Instruments are compared as well now.

Changeset: d373dabaa703c7e35a5de7612a49a385842d9157

comment:4 Changed 6 years ago by Michael Wedel

Refs #9711. Adjusted system test for PoldiMerge

Changeset: d60a974dd173d0abea7b7d6b7a2079bbd3aa9de0

comment:5 Changed 6 years ago by Michael Wedel

Refs #9711. Excluded new POLDI files from LoadLotsOfFiles

Changeset: 52d8d0194648243809e572d96eff0c4761813b0f

comment:6 Changed 6 years ago by Michael Wedel

Testing information

Code review. There is a system test in place which now also has data for a failing test.

comment:7 Changed 6 years ago by Michael Wedel

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:8 Changed 6 years ago by Michael Wedel

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:9 Changed 6 years ago by Michael Wedel

  • Status changed from reopened to inprogress

Refs #9711. Merging new data files

As explained in #10090, the measured chopper speed is sometimes a bit off on new data files. That's why the speed has to be cleaned up for now.

Changeset: e2a3548d4c8935ebd64e7230e55a389cb462f417

comment:10 Changed 6 years ago by Michael Wedel

  • Blocking 10090 added

(In #10090) Added block, because new system test in #9711 contains data that can be used for testing the new behavior.

comment:11 Changed 6 years ago by Michael Wedel

  • Status changed from inprogress to verify
  • Resolution set to fixed

Currently I don't see a better way to check whether the chopper speeds match, because instruments are not loaded at this point of the data processing. Maybe I will address this in another ticket if it turns out to be problematic, but for now this works.

comment:12 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:13 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9711_refactor_poldi_merge'

Full changeset: ​79ccf379c4fe6dbb12d06c4f53d6afe0d2a956b5

comment:14 Changed 6 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/feature/9711_refactor_poldi_merge'

Full changeset: ​6511764e8c26156f756e8e98a60d1f83cdb24e62

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10553

Note: See TracTickets for help on using tickets.