Ticket #9721 (closed: fixed)
Account for Groups When Setting YUnitLabel
Reported by: | Peter Parker | Owned by: | Peter Parker |
---|---|---|---|
Priority: | blocker | Milestone: | Release 3.2 |
Component: | SANS | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Martyn Gigg |
Description
#9710 inserted a line at the end of the reduction to apply a YUnit label to the result workspace. Unfortunately it failed to account for GroupWorkspaces.
Change History
comment:2 Changed 6 years ago by Peter Parker
- Status changed from assigned to inprogress
Refs #9721 - Correctly label WorkspaceGroups as well.
Changeset: 1db64a87e54a3e23b03725804695deaebbae2eee
comment:3 Changed 6 years ago by Peter Parker
- Status changed from inprogress to verify
- Resolution set to fixed
To test:
Make sure all system tests are passing. Then add the SANS2D and LOQ date file directories from the sytem test repo, and run the script below. Make sure all plots that pop up have their YUnit label set to I(q) (cm-1).
from ISISCommandInterface import * from SANSBatchMode import * #============================================================ # Check that group workspaces have their YUnit correctly set. #============================================================ SANS2D() Set1D() Detector("rear-detector") MaskFile('MASKSANS2Doptions.091A') Gravity(True) csv_file = FileFinder.getFullPath('SANS2D_multiPeriodTests.csv') # This might take a while. Sorry. BatchReduce(csv_file, 'nxs', saveAlgs={}) group = mtd["5512_SANS2DBatch"] plotSpectrum(group.getNames()[0], 0) #=================================================================== # Check that single workspaces still have their YUnit correctly set. #=================================================================== LOQ() Detector("main-detector-bank") MaskFile('MASK.094AA') SetDetectorOffsets('REAR', -1.0, 1.0, 0.0, 0.0, 0.0, 0.0) Gravity(True) AssignSample('99630.RAW') AssignCan('99631.RAW') result = WavRangeReduction(None, None, False) plotSpectrum(result, 0)
comment:4 Changed 6 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:5 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/9721_fix_isis_sans_yunitlabel_for_groups'
Full changeset: 9e816503f527dccf5f214ac29c877779e7ea88ca