Context Navigation

← Previous Ticket
Next Ticket →

Ticket #9731 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

LoadRaw LoadMonitors defaults have changed in dialog but not python

Reported by:	Martyn Gigg	Owned by:	Roman Tolchenov
Priority:	blocker	Milestone:	Release 3.3
Component:	Framework	Keywords:	CORE, Maintenance
Cc:		Blocked By:
Blocking:		Tester:	Martyn Gigg

Description

If you click load and then select a raw file the dialog is populated with the LoadRaw properties. The LoadMonitors combobox now has 1 as the default and running this separates out the monitors - a change from previous behaviour.

This has only affected the GUI as a call in Python produces the old result of monitors in the workspace.

Change History

comment:1 Changed 6 years ago by Nick Draper

Status changed from new to assigned

comment:2 Changed 6 years ago by Nick Draper

Keywords CORE, Maintenance added
Owner changed from Nick Draper to Roman Tolchenov
Milestone changed from Release 3.2 to Release 3.3

CORE CHANGE

Discussed this with Martyn, The best approach here is a change to Property which is not safe to do during the code freeze - therefore moved to the next maintenance period.

What this needs is:

Change the allowed properties validator to use a vector rather than a set, this will allow us to control the order of the options and refer to them using ordinal values.
Update property to allow input of an integer value to select lists (of strings only) using the ordinal value. Perhaps also only use ordinal value if there is no string of the number?
Change the LoadRaw LoadMonitors options so that 0=Exclude and 1=Seperate. Remove the 0 and 1 options.
Change the LoadRawDialog to remove the special code that prevents the old 0 and 1 options appearing.

comment:3 Changed 6 years ago by Roman Tolchenov

Status changed from assigned to inprogress

Re #9731. Changed allowed values storage type to vector

Changeset: fbd39acd5ea92fb6fe876958eca8a42b49931f6d

comment:4 Changed 6 years ago by Roman Tolchenov

Re #9731. Setting property values from aliases.

Changeset: ea6c2bc763b1b26eb9657baf0174c9f3f9124875

comment:5 Changed 6 years ago by Roman Tolchenov

Re #9731. Changed LoadRaw's LoadMinitors allowed values.

Changeset: 14817363045fdf6d6bb0853728d02aa65afea432

comment:6 Changed 6 years ago by Roman Tolchenov

Re #9731. Removed 0 and 1 treatment in LoadRawDialog.

Changeset: fdad08ba0654375a926bd9a765cd76e9f65a7715

comment:7 Changed 6 years ago by Roman Tolchenov

Merge branch 'bugfix/9731_loadmonitors_defaults' into develop

Conflicts:

Code/Mantid/Framework/Kernel/inc/MantidKernel/FileValidator.h Code/Mantid/Framework/Kernel/src/TimeSeriesProperty.cpp

Re #9731

Changeset: 03cfdf2882b42b147ff33b87096dc306295da8e7

comment:8 Changed 6 years ago by Roman Tolchenov

Re #9731. Fixing the builds.

Changeset: 0378de971ad4c43906449bb0d565b8073cacac97

comment:9 Changed 6 years ago by Roman Tolchenov

Merge branch 'master' into bugfix/9731_loadmonitors_defaults

Conflicts:

Code/Mantid/Framework/Kernel/inc/MantidKernel/FileValidator.h Code/Mantid/Framework/Kernel/src/TimeSeriesProperty.cpp

Re #9731

Changeset: fc7e7ca7ed8414e24f475004c445cf91f9c2894d

comment:10 Changed 6 years ago by Roman Tolchenov

Re #9731. Fixed errors after a merge.

Changeset: 08a5de4debc9e541ec68a02c3e838ec2313b5f37

comment:11 Changed 6 years ago by Roman Tolchenov

Merge branch 'bugfix/9731_loadmonitors_defaults' into develop

Conflicts:

Code/Mantid/Framework/Kernel/inc/MantidKernel/FileValidator.h Code/Mantid/Framework/Kernel/src/TimeSeriesProperty.cpp

Re #9731.

Changeset: 434badd8bf82d8bd820d8bea7e9149973929496e

comment:12 Changed 6 years ago by Roman Tolchenov

Re #9731. Fix unit test.

Changeset: 3d84741d36c8509c24daddf9da82548e80e731fb

comment:13 Changed 6 years ago by Roman Tolchenov

Status changed from inprogress to verify
Resolution set to fixed

To tester:

Check that Load's LoadMonitors option can be set in python either by passing 'Include', 'Excude', 'Separate' or '1' and '0'. This should work both with raw files and with event nexus ones.