Ticket #9759 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Tidy up IndirectILLReduction

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: minor Milestone: Release 3.3
Component: Indirect Inelastic Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

A few very minor points from Peter during testing:

One slight niggle would be that we should move the old-style *WIKI* string from the top of the file to the new-style summary method, as per, for example ​LoadVesuvio.py. Also, at around line 200 in IndirectILLReduction.py you have 

x = mtd[right_ws].readX(0)`

which can be deleted.

Change History

comment:1 Changed 6 years ago by Samuel Jackson

  • Priority changed from major to minor

comment:2 Changed 6 years ago by Samuel Jackson

Refs #9759 Fix minor issues in IndirectILLReduction.

Changeset: e66381eeaaf91068fd548bcc5690f2ca531e27e3

comment:3 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to verify
  • Resolution set to fixed

To Test

This is pretty trivial. Check the commit fixes the changes listed in the ticket description via code review.

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9759_tidy_up_indirectillreduction'

Full changeset: ​6063c354e2e1d8903698d26d18329a059cf83b50

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10601

Note: See TracTickets for help on using tickets.