Ticket #9780 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Workspace Binary ops shouldn't name workspace.

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: critical Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

There is another issue with history where we shouldn't name child algorithms. Unfortunately when I made the binary ops changes that is exactly what I did. Remove line 97 in DataProcessorAlgorithm.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #9780 Remove offending line.

Changeset: e521502a0b87493915dae37cb62912f4efb454f8

comment:3 Changed 6 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test

  • Open Mantid and run this script: 
    ws = Load('INTER000013463.nxs')
ws = CreateTransmissionWorkspaceAuto(ws)
  • Open the history for the workspace. Expand both the CreateTransmission algorithms and check unroll on CreateTransmissionWorkspaceAuto.
  • Click script to clipboard and paste the result into the script window.
  • Rename the "ws" workspace
  • Run the pasted script to generate a new workspace. This should match the one you just renamed.

comment:4 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:5 Changed 6 years ago by Nick Draper

  • Status changed from verifying to closed

comment:6 Changed 6 years ago by Nick Draper

Merge remote-tracking branch 'origin/bugfix/9780_workspace_ops_name'

Full changeset: ​624a715f45c5adee5b476713ee225874f2d22043

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10622

Note: See TracTickets for help on using tickets.