Ticket #9785 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Recycle Transmission Runs

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.2
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: #9470, #9797, #9851 Tester: Peter Parker

Description

The existing Quick gui, does not Keep Transmisson Workspaces. This should be an option (on by defualt). This will require a change to ReflectometryReductionOne and ReflectometryReductionOneAuto.

This is a request from Max Skoda

Attachments

test.tbl​ (1.8 KB) - added by Owen Arnold 6 years ago.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Owen Arnold

  • Status changed from assigned to inprogress

refs #9785. Export transmission workspace

Changeset: 1b3c8e3f83040a6e363d036c3be3daf4b0ea2651

comment:3 Changed 6 years ago by Owen Arnold

refs #9785. Do not clean workspace that doesn't exit

Changeset: fed3d9d336d4c56198c384dce0212d57ea80785d

comment:4 Changed 6 years ago by Owen Arnold

Tester

  • Open MantidPlot
  • On the Interfaces menu select Reflectometry->ISIS Reflectometry
  • When the interface opens, go to File and Open Table. Load the attached .tbl file
  • Set the instrument on the interface to 'INTER'
  • Hit the process button
  • Look in the MantidPlot workspace list, you should have transmission workspace called TRANS_{RunNo1}_{RunNo2} present

If you have the logs set to notify, you will see that there are TWO calls to ReflectometryReductionOneAuto, but ONLY one to CreateTransmissonWorkspaceAuto, this is because the transmission workspace can be reused. There should also be a notify log to this effect: Reusing transmission workspace TRANS_13463_13464

Last edited 6 years ago by Owen Arnold (previous) (diff)

Changed 6 years ago by Owen Arnold

comment:5 Changed 6 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Owen Arnold

  • Blocking 9470 added

comment:7 Changed 6 years ago by Owen Arnold

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:8 Changed 6 years ago by Owen Arnold

  • Status changed from reopened to inprogress

refs #9785. Identify and reuse the transmission runs

Changeset: fbdf0aaab41735bdadfddf7fbbb46c8c63855a01

comment:9 Changed 6 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:10 Changed 6 years ago by Owen Arnold

Follow the testing instructions above

comment:11 Changed 6 years ago by Owen Arnold

  • Blocking 9797 added

comment:12 Changed 6 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:13 Changed 6 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9785_recycle_transmission'

Full changeset: ​9ff8c060fefc1566f30de0d3b7fe18120433baff

comment:14 Changed 6 years ago by Peter Parker

Passing, but assuming:

  1. that the "Use ReflectometryReductionOneAuto" option in the Refl Gui Options dialog is supposed to be unchecked by default for clean installations of Mantid (I had to check it to get the expected output);
  1. that the "Division by zero: the RHS is a single-valued vector with value zero." warning at the end of the reduction is benign; and
  1. that "ReflectometryReductionOneBaseTest.py" was removed because the tests correspond to algorithms that no longer exist.

comment:15 Changed 6 years ago by Owen Arnold

Correct on all counts

comment:16 Changed 6 years ago by Owen Arnold

  • Blocking 9851 added

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10627

Note: See TracTickets for help on using tickets.