Ticket #9810 (closed: fixed)
SaveASCII: Add option to not write spectrum ID on single-spectrum workspaces
Reported by: | Mathieu Doucet | Owned by: | Mathieu Doucet |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Samuel Jackson |
Description
Since v2 of SaveASCII, a spectrum ID is written before each spectrum is written.
http://trac.mantidproject.org/mantid/ticket/7732#comment:6
Add an option to skip this behavior when saving workspaces with a single spectrum.
The default behavior should not change.
SANS reduction should be checked so that it skips the spectrum ID when saving I(Q).
Change History
comment:2 Changed 6 years ago by Mathieu Doucet
- Status changed from assigned to inprogress
Re #9810 Add option to SaveASCII
Changeset: e65f27fd3cb520277250fba9f6814bfbca41505a
comment:3 Changed 6 years ago by Mathieu Doucet
Re #9810 Add option to SaveASCII
Changeset: bf86a4a3b341ca0d00c666930bdbfbea537edc0b
comment:4 Changed 6 years ago by Mathieu Doucet
To test:
- Load your favorite 3-column ascii file and save it using SaveAscii. Make sure the output file doesn't have an index number before your 3-column data starts.
- Grep the code and make sure I didn't miss any calls to SaveAscii in the SANS code. They should all have WriteSpectrumID=False.
comment:5 Changed 6 years ago by Mathieu Doucet
- Status changed from inprogress to verify
- Resolution set to fixed
comment:6 Changed 6 years ago by Samuel Jackson
- Status changed from verify to verifying
- Tester set to Samuel Jackson
comment:7 Changed 6 years ago by Samuel Jackson
- Status changed from verifying to reopened
- Resolution fixed deleted
Looks like this isn't in develop. Might have been thrown off by a reset...
ERROR: Branch 'feature/9810_saveascii_spectrum_id' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments. Contact Mathieu Doucet on doucetm@ornl.gov (or via skype) and ask them to merge the code to develop using 'git checkbuild' from their branch feature/9810_saveascii_spectrum_id and let you know when it passes testing on the buildservers so you can start testing.
comment:8 Changed 6 years ago by Mathieu Doucet
- Status changed from reopened to verify
- Resolution set to fixed
OK try it now
comment:10 Changed 6 years ago by Samuel Jackson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9810_saveascii_spectrum_id'
Full changeset: b40b467bbb27c0c1ee8c5346e32140df9788781c
comment:11 Changed 6 years ago by Samuel Jackson
Changes look good to me. Works as I'd expect and I can't spot anything obviously SANS that hasn't been changed.
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10652