Ticket #9812 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Issues with LineViewer

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description (last modified by Owen Arnold) (diff)

LineViewer isn't identifying features from the 2D slice viewer plot.

  • Load the SEQMDEW file
  • View in the SliceViewer
  • Generate line Cuts. The preview looks right, but when you let go of the cursor, the BinMD generated plots are completely different. (See attachement generated by Jon Taylor)

Attachments

Screen Shot 2014-07-03 at 16.19.22.png (148.7 KB) - added by Owen Arnold 6 years ago.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner changed from Anyone to Owen Arnold

comment:2 Changed 6 years ago by Owen Arnold

This reproduces the issue on OSX. Mantid version taken from todays nightly builds:

Load(Filename='/Users/spu92482/Desktop/SEQ_Gd1.nxs', OutputWorkspace='SEQ_Gd1', LoaderName='LoadMD', LoaderVersion=1)
BinMD(InputWorkspace='SEQ_Gd1', AlignedDim0='[0,0,Ql], -5.000000, 2.200000, 200', AlignedDim1='[0.5Qh,0.866Qk,0], -3.000000, 3.000000, 200', AlignedDim2='DeltaE, -10.000000, 45.000000, 50', AlignedDim3='[Qh,0,0], -3.000000, 3.000000, 1', OutputWorkspace='SEQ_Gd1_visual_md')

# The following line was created using the LineViewer. The preview of the line is correct, but the actual line has missaligned peaks.
BinMD(InputWorkspace='SEQ_Gd1_visual_md', AxisAligned=False, BasisVector0='X,units,0.998714,0.0507049,0,0', BasisVector1='Y,units,-0.0507049,0.998714,0,0', BasisVector2='2,units,-0,-0,1,0', BasisVector3='3,units,-0,-0,0,1', Translation='-1.2454,-0.0275229,0,0', OutputExtents='0,2.38835,-0.141738,0.141738,-0.1,0.1,-0.1,0.1', OutputBins='100,1,1,1', OutputWorkspace='SEQ_Gd1_visual_md_line')

comment:3 follow-up: ↓ 8 Changed 6 years ago by Owen Arnold

Load(Filename='/Users/spu92482/Desktop/SEQ_Gd1.nxs', OutputWorkspace='SEQ_Gd1', LoaderName='LoadMD', LoaderVersion=1)
BinMD(InputWorkspace='SEQ_Gd1', AlignedDim0='[0,0,Ql], -5.000000, 2.200000, 200', AlignedDim1='[0.5Qh,0.866Qk,0], -3.000000, 3.000000, 200', AlignedDim2='DeltaE, -10.000000, 45.000000, 50', AlignedDim3='[Qh,0,0], -3.000000, 3.000000, 1', OutputWorkspace='SEQ_Gd1_visual_md')
BinMD(InputWorkspace='SEQ_Gd1_visual_md', AxisAligned=False, BasisVector0='X,units,0.999934,-0.0114657,0,0', BasisVector1='Y,units,0.0114657,0.999934,0,0', BasisVector2='2,units,-0,0,1,0', BasisVector3='3,units,-0,0,0,1', Translation='-1.43012,0.0325067,0,0', OutputExtents='0,1.54644,-0.23371,0.23371,-0.1,0.1,-0.1,0.1', OutputBins='100,1,1,1', OutputWorkspace='SEQ_Gd1_visual_md_line')
plotMD('SEQ_Gd1_visual_md_line') # Should contain two peaks at [0,0,Ql] = 0 and [0,0,Ql] = 1. Does in the preview, but not in the rebinned plot.

comment:5 follow-up: ↓ 6 Changed 6 years ago by Andrei Savici

Check if you have enough width of the line (same as the slice viewer). There is a ticket about that #5315

comment:6 in reply to: ↑ 5 Changed 6 years ago by Owen Arnold

Replying to Andrei Savici:

Check if you have enough width of the line (same as the slice viewer). There is a ticket about that #5315

Will do. I'm not sure that that's the real issue, but thanks for the pointer.

comment:7 Changed 6 years ago by Owen Arnold

Looks like the issue is not to do with BinMD. The issue seems to be in the 'Thickness' selection. The thickness for integrated dimensions should default to the full range for that dimension.

comment:8 in reply to: ↑ 3 Changed 6 years ago by Owen Arnold

Replying to Owen Arnold:

Load(Filename='/Users/spu92482/Desktop/SEQ_Gd1.nxs', OutputWorkspace='SEQ_Gd1', LoaderName='LoadMD', LoaderVersion=1)
BinMD(InputWorkspace='SEQ_Gd1', AlignedDim0='[0,0,Ql], -5.000000, 2.200000, 200', AlignedDim1='[0.5Qh,0.866Qk,0], -3.000000, 3.000000, 200', AlignedDim2='DeltaE, -10.000000, 45.000000, 50', AlignedDim3='[Qh,0,0], -3.000000, 3.000000, 1', OutputWorkspace='SEQ_Gd1_visual_md')
BinMD(InputWorkspace='SEQ_Gd1_visual_md', AxisAligned=False, BasisVector0='X,units,0.999934,-0.0114657,0,0', BasisVector1='Y,units,0.0114657,0.999934,0,0', BasisVector2='2,units,-0,0,1,0', BasisVector3='3,units,-0,0,0,1', Translation='-1.43012,0.0325067,0,0', OutputExtents='0,1.54644,-0.23371,0.23371,-0.1,0.1,-0.1,0.1', OutputBins='100,1,1,1', OutputWorkspace='SEQ_Gd1_visual_md_line')
plotMD('SEQ_Gd1_visual_md_line') # Should contain two peaks at [0,0,Ql] = 0 and [0,0,Ql] = 1. Does in the preview, but not in the rebinned plot.

I now understand that this doesn't work because the lineviewer has set bad default outputextents of (-0.1, 0.1 for the integrated dimension). These should be +3, -3

Changed 6 years ago by Owen Arnold

comment:9 Changed 6 years ago by Owen Arnold

  • Description modified (diff)

comment:9 Changed 6 years ago by Owen Arnold

  • Status changed from assigned to inprogress

refs #9812. Default to max integration width.

Changeset: f4d946192acb5a7f190b0a8fdc65092f4275a256

comment:10 Changed 6 years ago by Owen Arnold

  • Description modified (diff)

comment:11 Changed 6 years ago by Owen Arnold

Tester:

  • Run the script below
  • Open the binned 'SEQ_Gd1_visual_md' workspace in the SliceViewer
  • Use the screen shot to reproduce the plot. You should find that the 'Thickness' defaults to 3 not 0.1 for the integrated dimension and that upon releasing the end of the line, the integrated workspace is not zero as it was in the original screenshot. You should see a plot that matches the integrated line region selected (which should also closely match your your preview)
Load(Filename='/Users/spu92482/Desktop/SEQ_Gd1.nxs', OutputWorkspace='SEQ_Gd1', LoaderName='LoadMD', LoaderVersion=1)
BinMD(InputWorkspace='SEQ_Gd1', AlignedDim0='[0,0,Ql], -5.000000, 2.200000, 200', AlignedDim1='[0.5Qh,0.866Qk,0], -3.000000, 3.000000, 200', AlignedDim2='DeltaE, -10.000000, 45.000000, 50', AlignedDim3='[Qh,0,0], -3.000000, 3.000000, 1', OutputWorkspace='SEQ_Gd1_visual_md')

comment:12 Changed 6 years ago by Owen Arnold

  • Priority changed from major to critical

Update to critical, as this fix should get into the upcoming 3.2 release.

comment:13 Changed 6 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:14 Changed 6 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:15 Changed 6 years ago by Michael Reuter

#9844 was generated from observations while testing this ticket.

comment:16 Changed 6 years ago by Owen Arnold

refs #9812. Default to max integration width.

Changeset: 6300def9e91f92ea595b8d10c3e34cd16050608f

comment:17 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9812_line_viewer_defect'

Full changeset: 023aa5a092574ea3c11467326a6374e1f12b168e

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10654

Note: See TracTickets for help on using tickets.