Ticket #9823 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Usage examples saving to CSV count bytes, which differ for Windows

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 3.2
Component: Documentation Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: #9773 Tester: Nick Draper

Description

ExportSampleLogsToCSVFile-v1 and ExportExperimentLog-v1 have usage examples that create a CSV file then test the CSV file by counting bytes. This produces a different result and hence failure on (some) Windows machines

The SaveCSV usage example does not test the file.

Change History

comment:1 Changed 6 years ago by Karl Palmen

SaveDaveGrp-v1.rst tells me how to count the number of lines rather than bytes. It is not as simple as counting the bytes, because it involves opening and closing the file.

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Karl Palmen

  • Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Karl Palmen

I accidentally put the branch into ticket #9832 and with the help of Owen moved it to this ticket. The changeset is shown as the first changeset of #9832.

comment:5 Changed 6 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test check that the usage examples run OK on Windows and have ran OK on the build servers. Also check that the documentation is OK.

comment:6 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:7 Changed 6 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9823_csv_check'

Full changeset: ​19a9bc230ecf26c83b82ae46bf0c4cdfbe702be5

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10665

Note: See TracTickets for help on using tickets.