Ticket #9836 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Correct YUnitLabels for All Reduction Results

Reported by: Peter Parker Owned by: Nick Draper
Priority: major Milestone: Release 3.2
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description (last modified by Peter Parker) (diff)

From Richard, as a result of testing #9710:

Very minor issue:

#9710 Y axis units, “front” and “rear” detector data still get old units 1/cm when produced as part of a “merged”reduction, “rear” detector gets old units when part of a “both” reduction

Ie I think it is only putting the new units on the last one generated thus can still get some: You are overlaying plots from data having differing units!

Change History

comment:1 Changed 6 years ago by Peter Parker

  • Description modified (diff)

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Peter Parker

To test:

Add the LOQ data directory of the system tests repo to your managed directories, and run the following script. All plots that appear should have YUnitLabels of "I(q) (cm-1)".

from ISISCommandInterface import *

#======================================
# Test "merged" option
#======================================
LOQ()
Detector("main-detector-bank")
MaskFile('MASK.094AA')
SetDetectorOffsets('REAR', -1.0, 1.0, 0.0, 0.0, 0.0, 0.0)    
Gravity(True)

AssignSample('99630.RAW')
AssignCan('99631.RAW')

WavRangeReduction(None, None, False, combineDet='merged')

results = {
        "99630main_1D_2.2_10.0_merged" : "A_merged",
        "99630main_1D_2.2_10.0" : "A_rear",
        "99630HAB_1D_2.2_10.0" : "A_front"
}

for old_name, new_name in results.items():
        RenameWorkspace(InputWorkspace=old_name, OutputWorkspace=new_name)
        plotSpectrum(new_name, 0)

#======================================
# Test "both" option
#======================================
LOQ()
Detector("main-detector-bank")
MaskFile('MASK.094AA')
SetDetectorOffsets('REAR', -1.0, 1.0, 0.0, 0.0, 0.0, 0.0)    
Gravity(True)

AssignSample('99630.RAW')
AssignCan('99631.RAW')

WavRangeReduction(None, None, False, combineDet='both')

results = [
        "99630main_1D_2.2_10.0",
        "99630HAB_1D_2.2_10.0"
]

for result in results:
        plotSpectrum(result, 0)
Last edited 6 years ago by Peter Parker (previous) (diff)

comment:4 Changed 6 years ago by Peter Parker

  • Status changed from assigned to inprogress

Refs #9836 - Label front, back and merged for all det options.

Changeset: a0fe6389dd438252eb1deb3c3978613640ea2e49

comment:5 Changed 6 years ago by Peter Parker

Refs #9836 - Fix system tests.

Changeset: d5d894040fc66977d70cf6e275bbc0f40a3c34db

comment:6 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Owner changed from Peter Parker to Nick Draper
  • Resolution set to fixed

System tests passed last night

comment:7 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:8 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9836_more_y_unit_label_corrections'

Full changeset: c4a65ed1f3cb6b108db88da10cb4a9df0ed6f333

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10678

Note: See TracTickets for help on using tickets.