History needs to clear properties before filling

[Samuel Jackson]

In the fillAlgorithmHistory method in AlgorithmHistory we set the add all of the property histories from an algorithm to the object. The container should be cleared first so we don't end up with properties from another algorithm.

[Samuel Jackson]

Refs #9839 Clear the list of properties before setting them.

Changeset: e627969ce11c679b843d667458e75dc2d2c9db88

[Samuel Jackson]

To Tester

This is a small change that needs to be treated with caution. Follow all the instructions below to check the common and edge cases for history generation and check they all work.

First check that you can reproduce the original issue:

• Open Indirect > Convert to Energy.
• Choose IRS21360.raw from the auto test data as the run to use.
• Click run energy transfer
• Open the history
• Generate a script from the history
• Run the script.
• It should fail on SaveNexusProcessed because its arguments are duplicated.

Now apply the changes and repeat the above. The script should now work. Workspace generated by the script should match the original workspace. Some other things should also be checked. I've provided a script to help with this. The special case algorithms we need to check are:

• MergeRuns
• SaveNexus
• SaveNexusProcessed

Run the script and check that you can reproduce the same workspace from the history. The file used is in the system tests data.

[Nick Draper]

Other things came up

[Nick Draper]

Merge remote-tracking branch 'origin/bugfix/9839_history_clear_props'

Full changeset: ​d395af54269a048f449e98b747511fb569c8ca83

[Stuart Campbell]

This ticket has been transferred to github issue ​10681