Ticket #9847 (closed: fixed)
Crash on saving projects
Reported by: | Owen Arnold | Owned by: | Harry Jeffery |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.3 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | #9970 | |
Blocking: | Tester: | Lottie Greenwood |
Description
There seems to be an agreement amongst some users and groups that the MantidProject files are quite important.
- Users are reporting issues (crashes) when saving project files
- Users have the feeling that the project files are not stable
I don't have any more information than this at this stage.
This would be a good ticket for a new student to look at as it shouldn't require any specialist knowledge.
Change History
comment:5 Changed 6 years ago by Harry Jeffery
- Status changed from assigned to verify
- Resolution set to fixed
No crashes whilst were experienced when working on #9970, and a lot of work was carried out in that ticket to improve stability. Crashing ought not be a problem any more.
Testing
- Save a project with many different types of windows open.
- See if it crashes
Note: See
TracTickets for help on using
tickets.
Without clear steps on how to reproduce a crash, it's going to be difficult to identify the individual cause(s). I was unable to get it to crash myself.
I've looked through the loading/saving code and it's quite messy. We could fix smaller issues as they're found, but rewriting the project loading/saving code may be a better idea long term.
All of the project loading and saving code seems to be carrying a lot of technical debt at the moment. Paying it off (i.e. replacing it) would make it far easier to maintain long term and resolve the issue of stability. The trouble with that is it'd be a lot of work, it'd need extensive new testing, and it'd lose compatibility with any existing project files.