Ticket #9854 (closed: fixed)
History GUI unrolling defect.
| Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Karl Palmen |
Description (last modified by Samuel Jackson) (diff)
Unrolling from the GUI using history produced by the script attached to the ticket throws an error. This is because the iterator at line 513 needs to be a reverse iterator.
Attachments
Change History
comment:2 Changed 6 years ago by Samuel Jackson
Refs #9854 Use reverse iterator
Changeset: 8d231e312ea1fa6b0633218b5c9129d305b8e1ac
comment:3 Changed 6 years ago by Samuel Jackson
To Test
First check you can reproduce the error:
- Run the script provided.
- Open the history GUI.
- Expand ReflectometryReductionOneAuto and ReflectometryReductionOne.
- Check "Unroll" on ReflectometryReductionOne.
- An error message should appear
Now repeat with the changes applied and you should not get the error. Check script to clipboard and look at the script, you should see the children of ReflectometryReductionOne.
comment:5 Changed 6 years ago by Samuel Jackson
- Status changed from assigned to verify
- Resolution set to fixed
comment:7 Changed 6 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:8 Changed 6 years ago by Karl Palmen
I was able to reproduce having dealt with pathnames in the script and found out that "Open the history GUI" really means show history of the workspace 'test'.
comment:9 Changed 6 years ago by Karl Palmen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/9854_history_gui_unrolling'
Full changeset: ae98a62cc4844c5b36e92c7cb94d06028d52b25c
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10696
