Ticket #9862 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

LoadSQW does not work with file based workspaces any more

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

When trying to loadSQW large data file specifying file, which serves as file base, a bunch of error telling that the workspace is already file based is thrown.

Workspace does not, naturally become loaded.

Change History

comment:1 Changed 6 years ago by Alex Buts

I have also tried to load 20Gb sqw file on a machine with 500Gb of RAM and it does not work, so LoadSQW does not work on large files any more.

comment:2 Changed 6 years ago by Alex Buts

  • Milestone changed from Backlog to Release 3.3

part of #9307 ticket

comment:3 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Alex Buts

  • Status changed from assigned to inprogress

refs #9862 Initial commit fixing wrong dimensions binning

Changeset: 938d5f21da70a5d13c86c7b380481136581d4627

comment:5 Changed 6 years ago by Alex Buts

refs #9862 Enabled Gridbox setting file-based mode recursively

in the situation when it does not know the position of the data in the file.

Changeset: 815d786a37f4501601cebdc9ce019f65a5cc9e44

comment:6 Changed 6 years ago by Alex Buts

refs #9862 works in file mode but not calculates correct box positions

on HDD yet

Changeset: 52ab1bcc7fe3c8758a44b19a607ba6c12fa0c95d

comment:7 Changed 6 years ago by Alex Buts

refs #9862 Typos and the changes to createOrOpenMDWSgroup interface

Added return option, which tells if the data group already exists

Changeset: 1b576c869dee5a2b8d570c898d001c05783d4561

comment:8 Changed 6 years ago by Alex Buts

refs #9862 file based mode works but LoadMD all does not

It is the question if the reason is wrong SaveSQW format or problem with LoadMD

Changeset: 8549294a14d4a4c9d31ef27e84ffecc4c4596ef0

comment:9 Changed 6 years ago by Alex Buts

refs #9862 This should fix it.

Changeset: bb9cbc5f11c3eadf254f01c75688d4c1787590b2

comment:10 Changed 6 years ago by Alex Buts

refs #9862 System test for fixed loadSQW

Changeset: 9fa3a224ce80a960558026286698c8c2b79456f5

comment:11 Changed 6 years ago by Alex Buts

refs #9862 fixed memory based mode

and enabled multithreaded addition (not very efficient)

Changeset: d0029a007e43581a6e644e10550f81f2ba3a8f3b

comment:12 Changed 6 years ago by Alex Buts

refs #9862 fixing unit test

Strange, why these strings are hardcoded. Should be taken from SQW file. (prospective ticket)

Changeset: ee300bab8bc62dbde0d9a37c003492121558f903

comment:13 Changed 6 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

The ticket should be easy to test but the changes are both in mantid and system tests repositories + tester should pick up reference files from ftp://ftp.nd.rl.ac.uk/scratch/abuts/Ticket_9862/ and place them to the testing server which have sufficient space, into the path specified on BuildSQWTest.py (or modify this path). I've also tried to put these files on SNS dropbox account but this seems have very limited space (or it decided that it is my personal account)

Before the changes were applied, LoadSQW would fail on Test22meV2f.sqw file both in Memory and File-based mode. After the changes, it should be able to load the file and convert it into MD workspace.

System tests would skip the tests, which verify the load operations if no reference & source files were discovered, but the system tests pass with these files pass on my machine, so should pass on tests servers as well. Tester should verify this and put the test files both on the development and on the master test servers.

Last edited 6 years ago by Alex Buts (previous) (diff)

comment:14 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:15 Changed 6 years ago by Martyn Gigg

The problem seems to be with LoadSQW.cpp:634:

DimVectorOut[i].setNumBins(m_nBins[i]);

which comes from LoadSQWTest.h:296 when parsing the SQW dimensions for slice2D.sqw

comment:16 Changed 6 years ago by Martyn Gigg

I will disable the part of the failing test for now until it can be fixed.

comment:17 Changed 6 years ago by Martyn Gigg

  • Status changed from reopened to inprogress

Disable failing test while it is debugged.

Refs #9862

Changeset: 16b1445f4111a46f61eb00e94b3bc235a6feb9a1

comment:18 Changed 6 years ago by Alex Buts

refs #9862 fixing unit test for loadSQW slice

it seems, more efforts are needed to check the cases when image is not aligned with the data. The ticket #10214 is written to address this.

Changeset: a3144a03618ea8ea3b5354fde06a40dfb572fd1e

Last edited 6 years ago by Alex Buts (previous) (diff)

comment:19 Changed 6 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:20 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:21 Changed 6 years ago by Alex Buts

  • Status changed from verifying to closed

Merge branch 'master' into bugfix/9862_LoadSQWproblems

Full changeset: daa153a3e11d1c45f8ec3d1555d2bd9773f0b40d

comment:22 Changed 6 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/bugfix/9862_LoadSQWproblems'

Full changeset: 4ca7371ae396d18dbc010b85902046d50382272d

comment:23 Changed 6 years ago by Alex Buts

Merge branch 'master' into bugfix/9862_LoadSQWproblems

Full changeset: 7c61c2d217b3d56395670d3a89fbe25ab15e4cbc

comment:24 Changed 6 years ago by Martyn Gigg

Merge branch 'bugfix/9862_LoadSQWproblems'

Full changeset: 35fb71dbd67078a6c12dbc88dd67c50ac2bb183d

comment:25 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10704

Note: See TracTickets for help on using tickets.