Ticket #9876 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Rebin2D performance test

Reported by: Owen Arnold Owned by: Nick Draper
Priority: major Milestone: Release 3.3
Component: Tools Keywords: Student
Cc: Blocked By:
Blocking: Tester: Peter Parker

Description

The Rebin2D performance test is reporting a slight increase in processing time. I notice that the implementation of the test for performance ​https://github.com/mantidproject/mantid/blob/master/Code/Mantid/Framework/Algorithms/test/Rebin2DTest.h includes the setup steps for the workspace to rebin. This time should not be tracked in this test. Make the input workspace as part of the test object construction instead of within the test method for test_On_Large_Workspace()

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned
  • Owner changed from Anyone to Dan Nixon

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Build workspace before Rebin2D performance test

Refs #9876

Changeset: 481e8cae888eeb592cd20b8f99bbc1df8ec17c16

comment:3 Changed 6 years ago by Dan Nixon

Test time reduced by 0.08s when running only the Rebin2DTest (ctest -R Rebin2DTest).

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Resolution fixed deleted

This branch has been based off develop and not master. This needs fixing.

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to inprogress

Build workspace before Rebin2D performance test

Refs #9876

Changeset: 7c0c73b71685c789abaec8b1bd8cbffaaa25b285

comment:7 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:8 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:9 Changed 6 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9876_rebin2d_performance_test_fix_new'

Full changeset: ​5e1b0cd968645ad3e662e3651123a0853a563c90

comment:10 Changed 6 years ago by Nick Draper

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:11 Changed 6 years ago by Nick Draper

  • Status changed from reopened to inprogress

re #9876, fixes scoping issue

Changeset: 8ee158ebb439715413ebb25c76a0cf75135443db

comment:12 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Owner changed from Dan Nixon to Nick Draper
  • Resolution set to fixed

comment:13 Changed 6 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester changed from Nick Draper to Peter Parker

comment:14 Changed 6 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9876_fix_perf_test'

Full changeset: ​0861e6a45902024b2952f472025aee098b2b0779

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10718

Note: See TracTickets for help on using tickets.