Ticket #9900 (closed: fixed)
Slow Unit Tests for Roman Tolchenov
Reported by: | Owen Arnold | Owned by: | Roman Tolchenov |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | Framework | Keywords: | Maintenance |
Cc: | Blocked By: | ||
Blocking: | #9905 | Tester: | Owen Arnold |
Description (last modified by Owen Arnold) (diff)
We have a number of slow running unit tests which we need to fix as part of the 3.3 maintenance window. We are targeting test suits than execute in > 2 seconds on our clean rhel6 build servers. For IO tests (Loading & Saving) we have applied a more generous threshold of > 5 seconds.
See the full list to see which tests have been assigned to you: http://www.mantidproject.org/images/2/2f/Slow_tests.xlsx_-_Sheet1.pdf
Criteria
- Test suits (each test class instance) should execute in < 1 second as a rough target
- As a corollary to the above, If the test suite contains lots of test methods aim for < 0.1 second per test method
- If for some reason you get the speed up the test below the target using the strategies listed below, you need to justify why when you close the ticket.
Guidelines/instructions to help
- Keep tests readable and improve code readability where possible. Unit tests are documentation.
- Do not delete test methods without good reason. We do not want to reduce test coverage
- Changing the algorithm code to improve speed is OK, but exercise caution. Add additional test coverage if it's not already good enough.
- Take test methods that are slow and involve IO, or are processor intensive and make them into system tests. Integration tests are not Unit tests.
- Most of the speed improvements will probably come from better selection of input data. Caching input data is also a good option.
- Create sub tickets for algorithms or groups of algorithms to help testability if you wish, but mark this ticket as the 'blocked' by each one.
Change History
comment:1 Changed 6 years ago by Owen Arnold
- Status changed from new to assigned
- Owner changed from Martyn Gigg to Roman Tolchenov
- Description modified (diff)
- Summary changed from Slow Unit Tests for Martyn Gigg (cloned) to Slow Unit Tests for Roman Tolchenov
comment:3 Changed 6 years ago by Roman Tolchenov
- Status changed from assigned to inprogress
Re #9900. PlotAsymmetryByLogValueTest.
Changeset: 2d95a2387d1ef896dec2e4c55a2e212cddb6f2dd
comment:4 Changed 6 years ago by Roman Tolchenov
Re #9900. CreateChunkingFromInstrumentTest
Changeset: c709d9d3d629c850f4b066da495acfc9c79970de
comment:5 Changed 6 years ago by Roman Tolchenov
Re #9900. Added CreateChunkingFromInstrumentTest.
Changeset: f766510870578e316405f71e9b9f4f42f70d2f2e
comment:6 Changed 6 years ago by Roman Tolchenov
Re #9900. Clean up.
Changeset: 2388717e9a8ddb486ed9a20a75969d05029b3078
comment:7 Changed 6 years ago by Roman Tolchenov
- Status changed from inprogress to verify
- Resolution set to fixed
The rest of the tests are loading ones and I cannot see ways of how to speed them up.
comment:8 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:9 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9900_slow_unit_tests'
Full changeset: 3cf295c26975beed66f393c8f1786b6b5e65b184
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10742