Ticket #9924 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

MSD fit parameters should be flipped.

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

Spotted by Franz. The output of MSD fit should be flipped. This is because it is fitting to negative values, but the parameter it's measuring should only ever be positive.

Change History

comment:1 Changed 6 years ago by Samuel Jackson

Refs #9924 Flip the parameter in the table.

This will also correct the output workspaces as well.

Changeset: aa7f5a73977ec38d505ac0ea0ae77a2380dfb98d

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to verify
  • Resolution set to fixed

To Test

  • Run MSDFit with and without the changes applied.
    • Note that the A1 parameter workspace is now flipped.
  • Code Review

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9924_msd_param_flipped'

Full changeset: ​2c37c5ebfa85131d2b661053c594c594be89d60f

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10766

Note: See TracTickets for help on using tickets.