Ticket #9946 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Coverity - High Impact Outstanding issues in Kernel files

Reported by: Michael Reuter Owned by: Martyn Gigg
Priority: critical Milestone: Release 3.3
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

There are 4 more Coverity high impact outstanding issues in the Kernel module that you don't already have assigned to you.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Keywords Maintenance added

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Martyn Gigg

  • Status changed from assigned to inprogress

Fix uninitialized variable in DateValidator

Picked up by coverity. Refs #9946

Changeset: 2aeab171d336e810a12289e68dc7b3e801ebb29a

comment:4 Changed 6 years ago by Martyn Gigg

Add unit test for Matrix transpose.

Coverity detected an issue that looks like a false-positive but there was no unit test for it. Valgrind says there isn't and it looks like it is just an artifact of how the code/memory is Matrix is structured. Refs #9946

Changeset: fc973908a143fa324381ee337fa047c25d80209d

comment:5 Changed 6 years ago by Martyn Gigg

Fix coverity warning about thread-safe access in DataService

Refs #9946

Changeset: 71082f74eef0c5ec41e683c3d60c331defac7586

comment:6 Changed 6 years ago by Martyn Gigg

Style clean up in Kernel::DataService.

  • remove any mention of workspace
  • use camelCase naming rather than underscore naming

Refs #9946

Changeset: 3f886ae4418eb79e0686c4395b67939fc39d3d8b

comment:7 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: ​bugfix/9946_coverity_issues_kernel

Tester: Coverity on runs on master so as long as all tests are working then the only option here is a code review. All coverity issues assigned to me can be viewed here: ​https://scan6.coverity.com:8443/reports.htm#v23037/p10083/. This ticket only covers those in Kernel.

Last edited 6 years ago by Martyn Gigg (previous) (diff)

comment:8 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:9 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9946_coverity_issues_kernel'

Full changeset: ​3b05a438e58ac0ae1fe961e630b18ed72ce32fdf

comment:10 Changed 6 years ago by Anders Markvardsen

looks good to me plus addition style clean up

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10788

Note: See TracTickets for help on using tickets.