Ticket #995 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

Binary operations break sharing of X vectors when this is not necessary

Reported by: Martyn Gigg Owned by: Russell Taylor
Priority: major Milestone: Iteration 21
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description


Change History

comment:1 Changed 11 years ago by Nick Draper

  • Owner set to Russell Taylor
  • Status changed from new to assigned

comment:2 Changed 11 years ago by Russell Taylor

  • Status changed from assigned to accepted

comment:3 Changed 11 years ago by Russell Taylor

(In [3622]) Should have done this a long time ago..... Add methods to get and set the X data via a reference to the copy-on-write pointer. With the data behind the cow pointer, there's no reason why vectors can't be shared between as well as within workspaces. This will also make it a lot less fiddly to preserve sharing of X vectors in algorithms, and this has been done in BinaryOperation. Re #995.

comment:4 Changed 11 years ago by Russell Taylor

(In [3623]) Fix tests. Re #995.

comment:5 Changed 11 years ago by Russell Taylor

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:6 Changed 11 years ago by Martyn Gigg

  • Status changed from testing to closed

comment:7 Changed 11 years ago by Nick Draper

Tested by Adding two datasets together and then monitoring memory while running ConvertUnits on the result. Memory increased as ConvertUnits broke the memory sharing.

Tested in revision 3805

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1843

Note: See TracTickets for help on using tickets.