Ticket #9956 (closed: fixed)
SURF IDF
Reported by: | Owen Arnold | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | blocker | Milestone: | Release 3.2.1 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #9955 | Tester: | Nick Draper |
Description (last modified by Owen Arnold) (diff)
Dear Owen,
'LambdaMax' for SURF should really be 7.0 (see my previous email). Somebody must have changed it when they extracted the parameters into the separate parameters file...Please change it back to 7.0! I think that's why the GUI fails and produces the gap in the stitched data...
Thanks,
Max
Do ASAP. Email sent 18th July 2014
Change History
comment:2 Changed 6 years ago by Owen Arnold
- Status changed from new to assigned
- Description modified (diff)
- Milestone changed from Backlog to Release 3.3
comment:5 Changed 6 years ago by Owen Arnold
- Status changed from assigned to inprogress
refs #9956. IDF Params corrected
Checked the params against all those provided by Max.
Changeset: dfb8e87edfa0309fc7f00e7f200ada62f4fe0787
comment:7 Changed 6 years ago by Owen Arnold
Tester. The following should now print [7]
import os ws = LoadEmptyInstrument(os.path.join(config.getInstrumentDirectory(), "SURF_Definition.xml")) instrument = ws.getInstrument() print instrument.getNumberParameter('LambdaMax')
comment:8 Changed 6 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:9 Changed 6 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:10 Changed 6 years ago by Nick Draper
Code review is clear, a single change from 9 to 7
comment:11 Changed 6 years ago by Nick Draper
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9956_SURF_params'
Full changeset: 37df154ff57e5d55a98d441cc87cbee1a690b678
comment:12 Changed 6 years ago by Peter Peterson
- Milestone changed from Release 3.3 to Release 3.2.1
comment:14 Changed 6 years ago by Martyn Gigg
Cherry-pick fixes from feature/9956_SURF_params into next
Changes:
refs #9956. IDF Params corrected
Checked the params against all those provided by Max. (cherry picked from commit dfb8e87edfa0309fc7f00e7f200ada62f4fe0787)
Changeset: 5bea5c9bc91dd56cbc680619f3342a214d61e951
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10798