4D MD workspace always displays 10x10x10x10 dimensions regardless of internal binning.

[Alex Buts]

I believe this is because of dimensions, displayed in the workspace out of synch with whatever are the binning parameters.

e.g:

Load(Filename=r'D:\users\abuts\SVN\MantidTraining\RbMnF3\MAP05935_4to1_033.nxspe', OutputWorkspace='MAP05935_4to1_033', LoaderName='LoadNXSPE', LoaderVersion=1)
SetUB(Workspace='MAP05935_4to1_033', a=4.2275, b=4.2275, c=4.2275, u='1,1,0', v='0,0,1')
SetGoniometer(Workspace='MAP05935_4to1_033')
SetGoniometer(Workspace='MAP05935_4to1_033', Axis0='psi,0,1,0,1')
ConvertToMD(InputWorkspace='MAP05935_4to1_033', QDimensions='Q3D', Q3DFrames='HKL', QConversionScales='HKL', OutputWorkspace='MAP05935_4to1_033MD',SplitInto='50,50,50,60')

The if one looks at the resulting workspace, it has 10x10x10x10 bins when should be 50x50x50x60

[Alex Buts]

part of #9307 ticket

[Alex Buts]

refs #9961 Spelling errors.

Changeset: 5bd671baa680e25f16a3a0399dc3a7b3a8ad3ae8

[Alex Buts]

refs #9961 This should fix the issue

Changeset: d54cf3d6066939b765b535b8996e208c43a41db7

[Alex Buts]

to test run the script

Load(Filename='MARIReduction.nxs', OutputWorkspace='MARIReduction', LoaderName='LoadNexusProcessed', LoaderVersion=1)
ConvertToMD(InputWorkspace='MARIReduction', QDimensions='|Q|', QConversionScales='HKL', OutputWorkspace='mdWs1', SplitInto='100,100', MaxRecursionDepth=1)

where MARIReduction.nxs is the file present in the system test area and right click on the resulting workspace before and after applying the patch.

Before applying the fix the workspace shows 10x10 bins while after it has 100x100 bins as expected.

Tester can try and run Q3D MD conversion for some other workspace e.g. the one, described in the ticket itself

[Alex Buts]

refs #9961 unit test for the changes

Changeset: 211c96b91841e58dd2c033a20f9806c55e666187

[Alex Buts]

refs #9961 Doxygen errors

Changeset: 854336a33c718b0943216e2eef22b4e9ca2e04f5

[Martyn Gigg]

There is a compiler warning in MDWSDescription: ​http://builds.mantidproject.org/job/develop_incremental/1223/warnings18Result/

[Alex Buts]

refs #9961 Compiler warnings

Changeset: 61a8a1ff0ca417e15e62823a1d74adfd3a886a5c

[Martyn Gigg]

Some systemtests have broken around the ConvertToMD workflow: ​http://builds.mantidproject.org/job/develop_systemtests_rhel6/392/

[Alex Buts]

refs #9961 should fix ConvertToMDworkflow test

Changeset: 257d43ad62eec32010db52838b783e75b017f63a

[Alex Buts]

refs #9961 This should fix 2 or all SNS MD tests

Changeset: e0ab1e379bbfbae54641e36669eb16fe06dc3ab5

[Alex Buts]

One can easy test the ticket as described above.

The changes are simple but are both in Mantid and SystemTests repositories, so both have to be merged to masters.

In addition, two files from ​ftp://ftp.nd.rl.ac.uk/scratch/abuts/14_07_31/ should be placed to the server (see extract from Skype conversation below), which runs system tests for the master branch if such server exists, so I suspect limited number of possible testers.

===

Attn to SNS people who uses ConvertToMD I've fixed minor bug in convertToMD, which was causing any new workspace created by convertToMD have 10x10x10x10 dimensions greed regardless of internal binning now the dimension binning coincides with the grid binning. As the one of the consequences, SNS ConvertToMD tests are failing because checks reports that the binning have changed. Other stuff inside these files looks OK, so I am replacing the old with the new one but please, beware about this. [31/07/2014 13:34:40] Alex B: and think if this change can affect anything else. [31/07/2014 13:39:12] Vickie Lynch: @Alex What do you mean you are replacing the old with the new one? Are you going to fix the broken system tests? [31/07/2014 13:44:39] Alex B: yes -- I've fixed the tests on my machine but the only way to fix them globally is to replace the reference files [31/07/2014 13:44:53] Alex B: I've already replaced two which are on Git [31/07/2014 13:45:23] Alex B: there are two, which are to big to be on Git, and located on some SNS server [31/07/2014 13:46:11] Alex B: I have to ask somebody from SNS who has appropriate authority to do that, replace these couple too. New files are on ​ftp://ftp.nd.rl.ac.uk/scratch/abuts/14_07_31/ [31/07/2014 13:47:02] Alex B: I had a look at these files (the one I have) and anything except dimensions looks the same but you welcome to have a look by yourself [31/07/2014 15:24:28] Alex B: btw, the files on SNS test server should be in /home/builder/data/SystemTests/AnalysisTests/ReferenceResults folder

[Alex Buts]

This is simple low-risk bugfix, which would greatly enhance VATES usability.

[Martyn Gigg]

Merge remote-tracking branch 'origin/bugfix/9961_wrongMDBinning'

Full changeset: ​141d2fe345a0330f2f1f9fd76c5a18c9ddbdd8f3

[Martyn Gigg]

Merge remote-tracking branch 'origin/bugfix/9961_wrongMDBinning'

Full changeset: ​56e6bac2d721fbc0482c886a088496f594423fbf

[Alex Buts]

Merge branch 'bugfix/9961_wrongMDBinning'

Full changeset: ​892336c61315f7161ad987b2aa148d2af3374646

[Alex Buts]

Cherry-pick fixes from bugfix/9961_wrongMDBinning into next

Changes:

refs #9961 Spelling errors. (cherry picked from commit 5bd671baa680e25f16a3a0399dc3a7b3a8ad3ae8)

refs #9961 This should fix the issue (cherry picked from commit d54cf3d6066939b765b535b8996e208c43a41db7)

refs #9961 unit test for the changes (cherry picked from commit 211c96b91841e58dd2c033a20f9806c55e666187)

refs #9961 Doxygen errors (cherry picked from commit 854336a33c718b0943216e2eef22b4e9ca2e04f5)

refs #9961 Compiler warnings (cherry picked from commit 61a8a1ff0ca417e15e62823a1d74adfd3a886a5c)

Changeset: 3888445cd6fc46f9839762e19bfcdf306f5794a0

[Alex Buts]

Cherry-pick fixes from bugfix/9961_wrongMDBinning into next

Changes:

refs #9961 should fix ConvertToMDworkflow test (cherry picked from commit 257d43ad62eec32010db52838b783e75b017f63a)

refs #9961 This should fix 2 or all SNS MD tests (cherry picked from commit e0ab1e379bbfbae54641e36669eb16fe06dc3ab5)

Changeset: 06ea355c34e06e00258da3f289e06dde02f62bd3

[Stuart Campbell]

This ticket has been transferred to github issue ​10803