Ticket #9966 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Split direct and indirect interfaces

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: GUI Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester:

Description

Split indirect and direct convert to energy interfaces such that the two function independently of each other.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Dan Nixon

Initial separation of direct and indirect

Indirect seems to work fine, but direct has been broken Refs #9966

Changeset: 3d468b9631473bbba47aaf27e222abbea6955601

comment:4 Changed 6 years ago by Dan Nixon

Made loading empty instument workspace async

Refs #9966

Changeset: 42422a40e9034dd4e391f44e6cd1354d9ec76b98

comment:5 Changed 6 years ago by Dan Nixon

  • Cc spencer.howells@… added

comment:6 Changed 6 years ago by Dan Nixon

Fix Ui issues with main C2E tab

Both driect and indiretc should work as before now. Added progress indicator for instument load algorithm.

Refs #9966

Changeset: 6c0648fe9fba7328d0c509e7041ec15dd3a95147

comment:7 Changed 6 years ago by Dan Nixon

Added warning when instrument fails to load

Refs #9966

Changeset: c3d0c80c4c4464796b1ca43a2d8432d6c79de18e

comment:8 Changed 6 years ago by Dan Nixon

Rename indirect interfcae to Indirect Data Reduction

Refs #9966

Changeset: 2e98487282c4d178fd02b59dcfc17a4284abf26d

comment:9 Changed 6 years ago by Dan Nixon

Fix issues caused by opening both direct and indirect

Refs #9966

Changeset: 94979f7b3a32fda6ce8ade4e27470ce803dcbb2c

comment:10 Changed 6 years ago by Dan Nixon

Fixed bug indirect mapping type display bug

On loading new window mapping type selected in combo box did not relate to what was shown on UI

Refs #9966

Changeset: 7761c05f5515602b8a443642c389d0f631b7b273

comment:11 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

Separated ConvertToEnergy class to DirectConvertToEnergy and IndirectDataReduction. Each new class and .ui file has the features of the other interface removed from it.

Testing involved ensuring the both direct and indirect interfaces work as they previously did.

comment:12 Changed 6 years ago by Dan Nixon

Fixed build issue casued by incorrect include filename

Refs #9966

Changeset: 10a97531366df3b1ebaba635c86f68454553742c

comment:13 Changed 6 years ago by Dan Nixon

Indirect/direct UI improvements

Made load instrument managed algorithm Restored original indirect layout (reflector & analyser on same line as instrument) Moved instrument loading warnings to log

Refs #9966

Changeset: 57679bc56be7b2d1f239144844c8d084b831c469

comment:14 Changed 6 years ago by Samuel Jackson

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/bugfix/9966_split_direct_and_indirect_interfaces'

Full changeset: 2aa1a7a3a05357334b7fbe1fdd5dbe448018e3ff

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10808

Note: See TracTickets for help on using tickets.