Ticket #9968 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Refactor indirect convert to energy tabs

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: GUI Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: #9969 Tester: Samuel Jackson

Description (last modified by Dan Nixon) (diff)

  • Separate each tab into it's own class
  • Clean up code for each tab
  • Move common code into either IndirectDataReductionTab or IndirectDataReduction
  • Remove Indirect class
  • Run button should just say "Run"
  • Make documentation/commenting more consistent
  • Clean up includes

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Cc spencer.howells@… added

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Initial setup of new tab classes

Refs #9968

Changeset: 320006519aa9395f5a27cee0ada5b799a8678c31

comment:4 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:5 Changed 6 years ago by Dan Nixon

Partially complete separation

Some functionality has been broken, but at the very least Convert to Energy still works

Refs #9968

Changeset: ad8bfe7181dfc6ff0751d3585486a83754339404

comment:6 Changed 6 years ago by Dan Nixon

Fix Plot Raw and rebin checkbox on Convert to Energy

Refs #9968

Changeset: 69c61be89ab60c5feca32bdb4d1845c871ba5a6a

comment:7 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:8 Changed 6 years ago by Dan Nixon

General refactoring and bugfixes

Tidied up includes, added exception for include giving compiler warnings

Refs #9968

Changeset: bf2f62628481bf2bf54ac482c4e0f3f86ca5f4b7

comment:9 Changed 6 years ago by Dan Nixon

Renamed Transmission to IndirectTransmission

Keeps it in line with naming convention of other indirect tabs

Refs #9968

Changeset: 9e736b5bb23584a49d634ae5f7618e6794e681ee

comment:10 Changed 6 years ago by Dan Nixon

Fixed segfault on opening indirect data analysis

Also moved run button slots to IndirectConvertToEnergy

Refs #9968

Changeset: 3042a5e4c1d0e4a24c898717bc445fc9ca0d74fb

comment:11 Changed 6 years ago by Dan Nixon

Improved error reporting on indirect tabs

Refs #9968

Changeset: 865114dcf2224fe3390a7cf6f923cefc6813a737

comment:12 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/9968_refactor_indirect_tabs' into develop

Refs #9968

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReductionTab.cpp

Changeset: 10d34b1cdc30d74d7c71d9706e56d9959b1af1ac

comment:13 Changed 6 years ago by Dan Nixon

Removal of Indirect class

Fixed issue with plots being rendered in top left of window

Refs #9968

Changeset: 5a6cca85736a9077906ea34882b15e6e1d683193

comment:14 Changed 6 years ago by Dan Nixon

Added signal connections for Python and message boxes

Refs #9968

Changeset: d86a203545e39483fcb05842bbd3556840da6eab

comment:15 Changed 6 years ago by Dan Nixon

Refactor Diagnostics to use plots, etc. in tab class

Refs #9968

Changeset: 7e61ea2c8f5c61730707181c43a128f22f472dd0

comment:16 Changed 6 years ago by Dan Nixon

Added more universal graphing/plotting to indirect tab

Refs #9968

Changeset: 73d0bf67de1f87630f2b555498a17027fdb547be

comment:17 Changed 6 years ago by Dan Nixon

Fix issue with QWidgets blocking UI

Refs #9968

Changeset: 5932b0da838cbc9e09808c5d4c52f9a01b1c121e

comment:18 Changed 6 years ago by Dan Nixon

Update spectra, peak and background min/max from C2E

Refs #9968

Changeset: 1cab3ba824def7934c53c5ea443400dae1857e23

comment:19 Changed 6 years ago by Dan Nixon

Refactoring and improvements to commenting

Refs #9968

Changeset: a38d4f03ef86f6ca954953bac306272906343560

comment:20 Changed 6 years ago by Dan Nixon

Removed old files, clean up C2E form validation

Also fixed Doxygen warnings

Refs #9968

Changeset: 15966385367d04c7b34217d9d9337623fffee689

comment:21 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:22 Changed 6 years ago by Dan Nixon

Merge branch 'master' into bugfix/9968_refactor_indirect_tabs

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataReductionTab.h Code/Mantid/MantidQt/CustomInterfaces/src/C2ETab.cpp

Refs #9968

Changeset: 66f30f5139a25cbadefe47e779cbd09888b7f095

comment:23 Changed 6 years ago by Dan Nixon

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:24 Changed 6 years ago by Dan Nixon

  • Blocking 9969 added

comment:25 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to inprogress

Fix issues with range selectors on calib. and diag.

Refs #9968

Changeset: b66dea96799f62be238297cc33aa6be5ebad6f47

comment:26 Changed 6 years ago by Dan Nixon

Fixed issues with mini plot guides

Renamed diagnostic ranges to peak and background

Refs #9968

Changeset: e111ff34627678984286b69baf16634e944f3c72

comment:27 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:28 Changed 6 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:29 Changed 6 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9968_refactor_indirect_tabs'

Full changeset: ​43fcb05e29eae952a0e46ca3b4756cb6637e7503

comment:30 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/9968_refactor_indirect_tabs' into develop

Refs #9968

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReductionTab.cpp

Changeset: 10d34b1cdc30d74d7c71d9706e56d9959b1af1ac

comment:31 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10810

Note: See TracTickets for help on using tickets.