Ticket #997 (closed: fixed)
Improve code quality in NormaliseToMonitor
Reported by: | Nick Draper | Owned by: | Russell Taylor |
---|---|---|---|
Priority: | major | Milestone: | Iteration 28 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Janik Zikovsky |
Description
Points raised
- Some inconsistency in member variable names across files: member variables here have m_ prefix, in other files they don't. Project coding standards state that prefixes won't be used.
- Implementation contains some large functions; consider refactoring.
Change History
comment:2 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 26 to Iteration 27
Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.
comment:3 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 27 to Iteration 28
Bulk move of tickets at the end of iteration 27
comment:4 Changed 9 years ago by Russell Taylor
- Status changed from new to accepted
- Component set to Mantid
comment:6 Changed 9 years ago by Russell Taylor
- Status changed from accepted to verify
- Resolution set to fixed
Refactoring done. The coding standards now state that prefixes are recommended so no change needed here.
comment:7 Changed 9 years ago by Janik Zikovsky
- Status changed from verify to verifying
- Tester set to Janik Zikovsky
Note: See
TracTickets for help on using
tickets.