Ticket #9976 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Skip spectra without detector in FilterEvents

Reported by: Wenduo Zhou Owned by: Peter Parker
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: roman.tolchenov@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Some instruments may have spectra without any detectors. Skip them during filtering. logging is required for these skipped spectra.

Change History

comment:1 Changed 6 years ago by Wenduo Zhou

Added workspace examination method. Refs #9976.

Changeset: d2f2a67b61bcb56057ee91c842aeb990af0003f7

comment:2 Changed 6 years ago by Wenduo Zhou

Enabled to skip spectra without detectors. Refs #9976.

Changeset: 393d940735a411cec2ea2883379d81dfb9c2996a

comment:3 Changed 6 years ago by Wenduo Zhou

For tester

With the change in this ticket, you can have this script running:

ws = Load(Filename="WISH00028816.nxs")

spliterWS, infoWS = GenerateEventsFilter(InputWorkspace=ws, FastLog=True, LogName='ORC_cycle', MinimumLogValue=522.0)

FilterEvents(InputWorkspace=ws, SplitterWorkspace=spliterWS, OutputWorkspaceBaseName="Splitted", InformationWorkspace=infoWS, FilterByPulseTime=False, GroupWorkspaces=False,CorrectionToSample="Elastic",SpectrumWithoutDetector="Skip",SplitSampleLogs=False)

comment:4 Changed 6 years ago by Wenduo Zhou

  • Status changed from new to assigned

comment:5 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Resolution fixed deleted

There is a compiler warning in FilterEvents.cpp on Windows:

​http://builds.mantidproject.org/job/develop_clean/label=win7-build/237/warnings32Result/source.457/#317

Could we take care of that, please?

comment:7 Changed 6 years ago by Wenduo Zhou

  • Status changed from reopened to inprogress

Fixed a windows warning. Refs #9976.

Changeset: efff6c8236d49f9c01f2cf969ce55f6c52371aca

comment:8 Changed 6 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Owner changed from Wenduo Zhou to Roman Tolchenov
  • Resolution set to fixed

comment:9 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:10 Changed 6 years ago by Peter Parker

  • Owner changed from Roman Tolchenov to Peter Parker
  • Status changed from reopened to verify
  • Resolution set to fixed

comment:11 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:12 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9976_filter_event_no_det'

Full changeset: ​5fc383bc56daf2fc4f197cd45bef4db45a391672

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10818

Note: See TracTickets for help on using tickets.