Ticket #9985 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

IDA: Use SortXAxis in MSDFit and ElWin

Reported by: Samuel Jackson Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description (last modified by Samuel Jackson) (diff)

There are a couple of places where we are manually flipping the x axis so it is in increasing order. I think we can probably replace those bits of code with the SortXAxis algorithm

For example, line ~299 in IndirectDataAnalysis.py: 

    if(datTx[0] > datTx[-1]):
        # if so reverse data to follow natural ordering
        datTx = datTx[::-1]
        datTy = datTy[::-1]
        datTe = datTe[::-1]

Change History

comment:1 Changed 6 years ago by Samuel Jackson

  • Description modified (diff)
  • Summary changed from IDA: Use SortX in MSDFit and ElWin to IDA: Use SortXAxis in MSDFit and ElWin

comment:2 Changed 6 years ago by Nick Draper

  • Owner changed from Samuel Jackson to Dan Nixon

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Dan Nixon

  • Milestone changed from Backlog to Release 3.3

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Replaced one usage in IDA:elwin

Refs #9985

Changeset: 45fa64196f8b29451cd804ead92f9ef2ab5afb85

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

I only managed to find the one instance of this in the inelastic scripts.

To Test:

  • Ensure Indirect Data Analysis > Elwin still works as intended (usage guide here)

comment:7 Changed 6 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:8 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9985_flip_ida_arrays_with_sortxaxis'

Full changeset: ​1ed18e7c514025db64e8e0d48b027ba63a11f3a5

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10827

Note: See TracTickets for help on using tickets.