Ticket #10306 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Indirect tabs become unusable after an invalid run has been entered in Energy Transfer

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By: #7860, #9969, #10451
Blocking: #10266 Tester: Raquel Alvarez Banos

Description

The Energy Transfer tab disables the Run button when an invalid run has been entered, this makes all other tabs unusable even if they have valid data.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Summary changed from Indirect tabs become unusable after an invlid run has been entered in Energy Transfer to Indirect tabs become unusable after an invalid run has been entered in Energy Transfer

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Added slot to update run button, reset when tab switched

Refs #10306

Changeset: facf7dc75ab97d6f47109bb7a902b7c00c734d2d

comment:4 Changed 6 years ago by Dan Nixon

Disable the rRun button when tab is already running

Refs #10306

Changeset: 4023bc425e91ebae1190df14098ea5f643f68498

comment:5 Changed 6 years ago by Dan Nixon

Other changes made to the way the Run button works:

  • Disabled when tab is running (requires that tabs use algorithms (i.e. no Python))
  • Disabled state is reset when switching between tabs
  • Disabled when loading an instrument or when instrument loading fails
Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:6 Changed 6 years ago by Dan Nixon

  • Blocked By 9969 added

comment:7 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10306_better_run_button_handling_in_idr

Refs #10306

Changeset: fc39fbc7093ca829b2af3689d071292c82ae01c5

comment:8 Changed 6 years ago by Dan Nixon

Added file finder feddback to Calib and Diag run buttons

Refs #10306

Changeset: 24cca11a93f054ce766ace34be1c16edf4574872

comment:9 Changed 6 years ago by Dan Nixon

  • Blocked By 7860 added

comment:10 Changed 6 years ago by Dan Nixon

  • Blocking 10266 added

comment:11 Changed 6 years ago by Dan Nixon

Merge branch 'feature/7860_indirect_symmetrise' into feature/10306_better_run_button_handling_in_idr

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataReduction.h Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReduction.cpp

Refs #10306

Changeset: b3a91d13502a595bbc8f4a8f1c5e0bd2bfd87c89

comment:12 Changed 6 years ago by Dan Nixon

Fix doxygen warnings

Refs #10306

Changeset: 03038b770efca289a48a178202f459a038eee90c

comment:13 Changed 6 years ago by Dan Nixon

  • Blocked By 10451 added

comment:14 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10306_better_run_button_handling_in_idr

Refs #10306

Changeset: a30208b55ae02e932b685154edffe5d9d873f42c

comment:15 Changed 6 years ago by Dan Nixon

To test:

  • Open Indirect > Data Reduction
  • Enter an invalid (e.g. 7492374) run number in the Energy Transfer tab, the Run button should be disabled
  • Switch to another tab, the Run button should be reset
  • Switch back to Energy Transfer and enter a range of run number (e.g. IRIS: 26173-26176) that will take a reasonable time to reduce
  • Click Run, the button should be disabled and re-enabled when the algorithm is complete
Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:16 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:17 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez Banos

comment:18 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge branch 'master' into feature/10306_better_run_button_handling_in_idr

Refs #10306

Full changeset: ​fc39fbc7093ca829b2af3689d071292c82ae01c5

comment:19 Changed 6 years ago by Dan Nixon

Merge branch 'feature/7860_indirect_symmetrise' into feature/10306_better_run_button_handling_in_idr

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataReduction.h Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReduction.cpp

Refs #10306

Full changeset: ​b3a91d13502a595bbc8f4a8f1c5e0bd2bfd87c89

comment:20 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10306_better_run_button_handling_in_idr

Refs #10306

Full changeset: ​a30208b55ae02e932b685154edffe5d9d873f42c

comment:21 Changed 6 years ago by Raquel Alvarez Banos

Merge remote-tracking branch 'origin/feature/10306_better_run_button_handling_in_idr'

Full changeset: ​d5725ef26d88de3413c6c49c0a58b4095e84bec1

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11148

Note: See TracTickets for help on using tickets.