Ticket #10311 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

CheckWorkspacesMatch returns 'did not match' when comparing a workspace to itself

Reported by: Jose Borreguero Owned by: Peter Peterson
Priority: critical Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: mareuter

Description

CheckWorkspacesMatch fill string result with 'Success' if workspaces match, but then a non-empty result variable is interpreted as failure

Change History

comment:1 Changed 6 years ago by Peter Peterson

  • Owner changed from Wenduo Zhou to Peter Peterson
  • Status changed from new to assigned

comment:2 Changed 6 years ago by Pete Peterson

  • Status changed from assigned to inprogress

Re #10311. Adding more operator== to TimeSeriesProperty.

In the interest of speeding up comparisons, let TimeSeriesProperty check for equality against a generic Property and do the casting check.

Changeset: d5427fcc99fba9f5682cdbb0a476ca433ef4e1d9

comment:3 Changed 6 years ago by Pete Peterson

Re #10311. Added PropertyWithValue::operator==.

Changeset: be6f22169ddc4caa15ce3bc1ba04b1142799c248

comment:4 Changed 6 years ago by Pete Peterson

Re #10311. Adding Property::operator==

Changeset: 37035d19a75d3e57ce5bea01ce66c5eee602eb1e

comment:5 Changed 6 years ago by Pete Peterson

Re #10311. Using new comparitor and adding openmp to log checks.

Changeset: 41d90acdc616dbad6801c0223c38fcab27d10cb4

comment:6 Changed 6 years ago by Pete Peterson

Re #10311. Fixing bug in comparison.

Changeset: 4be8a37eb22c7e2e1960ba0b59bfd221d122696c

comment:7 Changed 6 years ago by Pete Peterson

Re #10311. Fixing CheckWorkspacesMatch strings.

Changeset: 6afefd1d059d85db80d48a653be3eb2de7b77318

comment:8 Changed 6 years ago by peterfpeterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #39.

comment:9 Changed 6 years ago by mareuter

  • Status changed from verify to verifying
  • Tester set to mareuter

comment:10 Changed 6 years ago by Pete Peterson

Re #10311. Forgot that openmp on windoze requires signed ints.

Changeset: e5038bf1901716a09f6fcc9c5f1dd20109aef76c

comment:11 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge pull request #39 from mantidproject/bugfix/10311_checkworkspacesmatch

CheckWorkspacesMatch returns 'did not match' when comparing a workspace to itself

Full changeset: ​903037277d5178705197d993feaddd9dde3dbd8b

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11153

Note: See TracTickets for help on using tickets.