Ticket #10323 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

VESUVIO diffraction

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By: #10215
Blocking: #10278 Tester: Harry Jeffery

Description

There are issues with using the current Indirect Diffraction interface with VESUVIO:

  • The parameter file does not have the required workflow information about the monitors (also fixed by loading using LoadVesuvio with a PAR file)
  • MSGDiffractionReduction only outputs a single workspace with a single spectra, Andrew would like it to output a workspace for each spectra

The easiest way to ix this is likely to create a separate diffraction algorithm for VESUVIO and integrate it into the Indirect Diffraction UI (adding a field for the PAR file).

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Merge branch 'feature/10215_clean_indirect_diffraction_ui' into feature/10323_vesuvio_diffraction

refs #10323

Changeset: 9860b688124fb075061b2394fd111a009bfd79ca

comment:3 Changed 6 years ago by Dan Nixon

Modified existing MSGDiffRed algorith for Vesuvio

Refs #10323

Changeset: eec972f34e9be0bec19f1ff444b32aaaefe4b3e9

comment:4 Changed 6 years ago by Dan Nixon

Corrected naming, do not sum when only one file given

Refs #10323

Changeset: d756244389c7af7897b4e70ec131b6a77245c47c

comment:5 Changed 6 years ago by Dan Nixon

Added more realistic monitor data to IPF

Refs #10323

Changeset: 53155ca651682bb3433aadea099d2fc079abbf70

comment:6 Changed 6 years ago by Dan Nixon

Added option to plot contour when using ind. groups

Disable individual grouping for OSIRIS diffonly

Refs #10323

Changeset: f841acf595c0a2ce5a2a420aae6fccc7552ce99b

comment:7 Changed 6 years ago by Dan Nixon

  • Blocking 10278 added

comment:8 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10323_vesuvio_diffraction

Refs #10323

Changeset: 62a236562240b1002978db6d018b0a2101b842a8

comment:9 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:10 Changed 6 years ago by Dan Nixon

To test:

  • Open Indirect > Diffraction
  • Select VESUVIO
  • Load a sample file (e.g. 17297 from the data archive or 15289 from system tests)
  • Select plot type Spectra and click Run
  • Now enable Use Individual Grouping and select plot type Contour and click Run
  • (This does not perform grouping and leaves each detector in its own spectrum, which is used by instrument scientists to verify the detector positions)

comment:11 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:12 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge branch 'feature/10215_clean_indirect_diffraction_ui' into feature/10323_vesuvio_diffraction

refs #10323

Full changeset: 9860b688124fb075061b2394fd111a009bfd79ca

comment:13 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10323_vesuvio_diffraction

Refs #10323

Full changeset: 62a236562240b1002978db6d018b0a2101b842a8

comment:14 Changed 6 years ago by Harry Jeffery

Merge remote-tracking branch 'origin/feature/10323_vesuvio_diffraction'

Full changeset: e6e3deb71ed06b88d9c175ccb12b2264a19d47f5

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11165

Note: See TracTickets for help on using tickets.