Ticket #10453 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Better handle resetting variables for run

Reported by: MarcusNoble Owned by: MarcusNoble
Priority: critical Milestone: Release 3.3
Component: Framework Keywords: AUTOREDUCTION
Cc: doucetm@…, tom.griffin@…, nick.draper@…, anders.markvardsen@… Blocked By:
Blocking: #10147, #10412 Tester: Anders Markvardsen

Description (last modified by MarcusNoble) (diff)

When re-submitting a reduction run is isn't entirely clear what variables are being used.

Possible replace the "Reset to default variables" button with some sort of "Not the variables you were expecting?" link that shows a modal with more options.

Options:

  • Variables used by selected run
  • Default variables for original run number
  • Default variables now

This change will also affect "run_summary" and and "run_confirmation" in the reduction_variables/views.py file

For Tester:

  1. Navigate to: ​http://datareducedev.isis.cclrc.ac.uk/autoreduce_webapp/runs/52172/0/
  2. Verify the action links on the right, hover over them and verify additional information is shown.

Change History

comment:1 Changed 6 years ago by MarcusNoble

  • Status changed from new to assigned

comment:2 Changed 6 years ago by MarcusNoble

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by MarcusNoble

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

comment:4 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:5 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

For run #52355

Changing Testing to test9999.

Subsequent clickes on Reset to default values to not reset this parameter

comment:6 Changed 6 years ago by MarcusNoble

  • Status changed from reopened to verify
  • Resolution set to fixed

Now fixed. Please try again.

comment:7 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying

comment:8 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Now works.

Minor thing: when I went to 52355 on only had one parameter to change the value of. After clicking 'Reset to default...' I had 4, and it then stayed this way

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11295

Note: See TracTickets for help on using tickets.