Context Navigation

Ticket #10576 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Multi-dataset fitting interface: provide easier ways to set local parameters

Reported by:	Roman Tolchenov	Owned by:	Roman Tolchenov
Priority:	major	Milestone:	Release 3.4
Component:	GUI	Keywords:
Cc:	james.lord@…	Blocked By:	#8911
Blocking:	#11088	Tester:	Dan Nixon

Description (last modified by Roman Tolchenov) (diff)

Currently the local parameters have to be set manually individually. There needs to be an easy way to set them all to the same value at the same time or to values from logs. Make it easier to fix parameters.

Change History

comment:1 Changed 6 years ago by Nick Draper

Status changed from new to assigned

comment:2 Changed 6 years ago by Nick Draper

Moved to the backlog at the code freeze of R3.3

comment:3 Changed 6 years ago by Nick Draper

Milestone changed from Release 3.3 to Backlog

comment:4 Changed 6 years ago by Roman Tolchenov

Milestone changed from Backlog to Release 3.4

comment:5 Changed 6 years ago by Roman Tolchenov

Cc james.lord@… added
Description modified (diff)
Summary changed from Multi-dataset fitting interface: provide a way to set all local parameters to the same value to Multi-dataset fitting interface: provide easier ways to set local parameters

comment:6 Changed 6 years ago by Roman Tolchenov

Blocked By 11088 added

comment:7 Changed 6 years ago by Roman Tolchenov

Blocking 11088 added
Blocked By 11088 removed

comment:8 Changed 6 years ago by Roman Tolchenov

Status changed from assigned to inprogress

Re #10576. Added custom editor for local parameters.

Changeset: f25d68772127b76a9f4a6146f5918bc753278a65

comment:9 Changed 6 years ago by Roman Tolchenov

Re #10576. Moved local parameter values to FunctionBrowser.

Changeset: 171f6e64de52e74badc1be162cab46ce6ae60355

comment:10 Changed 6 years ago by Roman Tolchenov

Re #10576. Keep local parameters after removing spectra.

Changeset: a25de3dc84b7c70639091f80795774a3e5bf9804

comment:11 Changed 6 years ago by Roman Tolchenov

Re #10576. Keep old local parameter values after adding spectra.

Changeset: e712a2ed4f6ca63f7dcf845c8e27ef87d84f1e50

comment:12 Changed 6 years ago by Roman Tolchenov

Re #10576. Allow canceling parameter editing.

Changeset: 1e0818ba5d9791a3130ea9f892e6104bf552996a

comment:13 Changed 6 years ago by Roman Tolchenov

For setting parameters from logs opened ticket #11451.

comment:14 Changed 6 years ago by Roman Tolchenov

Re #10576. Fixing local parameters.

Changeset: 32e3c4f438227f7eeb6aaf0cbc515168d27ef730

comment:15 Changed 6 years ago by Roman Tolchenov

Re #10576. Local parameter fixing.

Changeset: 1f53b678e715f99b008930025c81e38927acef8b

comment:16 Changed 6 years ago by Roman Tolchenov

Re #10576. Display when a local parameter is fixed.

Changeset: 565ef1bb51ebc7b3be61b2d182d6d136b87e02ab

comment:17 Changed 6 years ago by Roman Tolchenov

Re #10576. Paste local parameters from clipboard.

Changeset: c2f3da612bec1b44767d73fbee0f23a6cbe11842

comment:18 Changed 6 years ago by Roman Tolchenov

Re #10576. Copy values to the clipboard.

Changeset: b3a66c063cc90f631699e31a5f8f8caf9becdd66

comment:19 Changed 6 years ago by Roman Tolchenov

Re #10576. Refactored: put classes in their own files.

Changeset: ee6a7ad0afbd58dbdb3140e05acbc88349c94203

comment:20 Changed 6 years ago by Roman Tolchenov

Re #10576. Set a shortcut for fixing parameters.

Changeset: 3bf285d4abcf5301a154912d40fe023b3b13fed1

comment:21 Changed 6 years ago by Roman Tolchenov

Status changed from inprogress to verify
Resolution set to fixed

This is being verified as pull request #549.

comment:22 Changed 6 years ago by Roman Tolchenov

Re #10576. Added missing includes and declarations.

Changeset: 2190ff65e81eebecc2deb08dec715a6282b54b0e

comment:23 Changed 6 years ago by Roman Tolchenov

Re #10576. Added missing includes and declarations.

Changeset: 18aeed375a2a64d229ff1690b65280b0915da2a3

comment:24 Changed 6 years ago by Roman Tolchenov

Re #10576. Added missing include.

Changeset: 1fe7f70f2b24d9e628ed060b3f794be274babcf2

comment:25 Changed 6 years ago by Dan Nixon

Status changed from verify to verifying
Tester set to Dan Nixon

comment:26 Changed 6 years ago by Dan Nixon

I'm getting a couple of compiler warnings that don't seem to be being picked up on the build server: ` [ 88%] Building CXX object MantidQt/CustomInterfaces/CMakeFiles/CustomInterfaces.dir/src/MultiDatasetFit/MDFEditLocalParameterDialog.cpp.o /home/dan/testing-builds/test1/Code/Mantid/MantidQt/CustomInterfaces/src/MultiDatasetFit/MDFLocalParameterEditor.cpp:103:6: warning: unused parameter ‘widget’ [-Wunused-parameter]

bool LocalParameterEditor::eventFilter(QObject *widget, QEvent *evn)

[ 88%] Building CXX object MantidQt/CustomInterfaces/CMakeFiles/CustomInterfaces.dir/src/Muon/ALCBaselineModellingView.cpp.o /home/dan/testing-builds/test1/Code/Mantid/MantidQt/CustomInterfaces/src/MultiDatasetFit/MDFLocalParameterItemDelegate.cpp:23:10: warning: unused parameter ‘option’ [-Wunused-parameter]

QWidget* LocalParameterItemDelegate::createEditor(QWidget * parent, const QStyleOptionViewItem & option, const QModelIndex & index) const

/home/dan/testing-builds/test1/Code/Mantid/MantidQt/CustomInterfaces/src/MultiDatasetFit/MDFLocalParameterItemDelegate.cpp: In member function ‘virtual void MantidQt::CustomInterfaces::MDF::LocalParameterItemDelegate::paint(QPainter*, const QStyleOptionViewItem&, const QModelIndex&) const’: /home/dan/testing-builds/test1/Code/Mantid/MantidQt/CustomInterfaces/src/MultiDatasetFit/MDFLocalParameterItemDelegate.cpp:79:60: warning: conversion to ‘int’ from ‘double’ may alter its value [-Wconversion]

rect.adjust(rect.width() - fWidth, dHeight, 0 ,-dHeight);

/home/dan/testing-builds/test1/Code/Mantid/MantidQt/CustomInterfaces/src/MultiDatasetFit/MDFLocalParameterItemDelegate.cpp:79:60: warning: conversion to ‘int’ from ‘double’ may alter its value [-Wconversion] `

comment:27 Changed 6 years ago by Roman Tolchenov

Re #10576. Fix compiler warnings.

Changeset: f6896224626c44aa17b34d40b7628a8f2ff57903

comment:28 Changed 5 years ago by Dan Nixon

One other small issue is that when you fix parameters for all spectra using the Edit parameter values window, the tie that is created is editable but editing it does not change the value, this would be better being disabled like the tie created when fixing the value by selecting Fix from the context menu.