Ticket #10883 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Remove the RebinningCutter from the VSI

Reported by: Anton Piccardo-Selg Owned by: Anton Piccardo-Selg
Priority: major Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description (last modified by Owen Arnold) (diff)

The rebinningCutter with which we currently provide a rebinning service for MDEvent workspaces is being removed here.

Rebinning will eventually take place on the actual workspace outside of the VSI. This ticket provides a first cleaning step.

The rebinning must be reintroduced/reimplemented as part of this ticket! There should be no version in master which does not have this feature.

Attachments

MDEvent1.nxs (2.3 MB) - added by Anton Piccardo-Selg 6 years ago.
MDHisto1.nxs (164.6 KB) - added by Anton Piccardo-Selg 6 years ago.
Test script for removing rebin cutter.docx (18.9 KB) - added by Anton Piccardo-Selg 6 years ago.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned
  • Description modified (diff)

comment:2 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Work on filter issue after rebinning

Changeset: 46917e6d1451d595749e82b9cc2ecb42fc400d99

comment:4 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Improvements to the rebinning

Changeset: 6a083d1239adb8f46ad80d3c3b7119c45c115031

comment:5 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Fix for cut filter bug in paraview

Changeset: 5f94f2aeab7ebd2bb63f76c20d01e77ca1aa7368

comment:6 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Adding SliceMD option

Changeset: 05e18dd81f4aa9031c1f3c03b8050165b7b4762c

comment:7 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Solving merge issue with master

Changeset: 1e4232f8a7aa52a3d5226c6b59c4319c1ea29342

comment:8 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Making tweeks to rebin button

Changeset: 6d2ebf4fc40561bd2e02beec9a1f00b8244ef0fb

comment:9 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Resolve merge conflicts for rebinning

Changeset: 44b5211d213075fd54ee9ffcaf28e83a02b984f2

comment:10 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Fix for paraview bug in rebin mode

Changeset: ba8eb82ab0c64e6d5325cfdaf4cdbdd2621d430b

comment:11 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Tweaking rebin behaviour

Changeset: 7c6d16c204504f2ac44ff8e29e3fbecc4122822e

Changed 6 years ago by Anton Piccardo-Selg

Changed 6 years ago by Anton Piccardo-Selg

comment:12 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Remove unused variables

Changeset: 806beb9dab3b42716622b78ead5949babf276fef

comment:13 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Trying to fix paraview induced intel warnings

Changeset: deab6eec031862c9692c666d2dc3440ab958d9d0

comment:14 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Further fix for intel compiler warning

Changeset: a8fe1a29779b2c3a2d6f65a547d75a0029a80557

comment:15 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Further fixes to intel compiler warning

Changeset: 94370ad7aa3bbe421c970d6a20d01b16ad72ec9b

Changed 6 years ago by Anton Piccardo-Selg

comment:16 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from inprogress to verify
  • Resolution set to fixed

For Testing: Please find the testscript and the test data attached.

comment:17 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:18 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Resolved merge conflicts

Changeset: 16317d73cab9c34421d31eaab8e75ae42140d96f

comment:19 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Fix for workspace issues

Changeset: 35d45e78c7780f9054ed63896bc8841dbf8b67d2

comment:20 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Fixes for rebinning

Changeset: a038dfb2486a15da2d53984022febe57871331b8

comment:21 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Solving merge issue

Changeset: b1afd4f42b818c8ab42f6c95d4ab86dde8b91a32

comment:22 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Bugfix for empty data sets

Changeset: 6325d2b0db505f5fe71e11ea3cf48e474387406b

comment:23 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Fix for ghost image and bad time bugs

Changeset: 9a77c00446a18f9ce7b2243c4551e45983b7fa58

comment:24 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Fix for swithching with filter to splatterplot

Changeset: 1d5aa4c3abff6193a81e02ccdda36ef36a533cd9

comment:25 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Fix typo in VSI Cmake file

Changeset: 515c4181a37e79d3a3cd953af45a0745e9d274e3

comment:26 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Fix for coord_t in linux in the vtkNullUnstructuredGrid

Changeset: 3958afcc3d09b71b04d0435b81dc5b530ced0aba

comment:27 Changed 6 years ago by Anton Piccardo-Selg

Refs #10883 Fix for unused variables in RebinnedSourcesManager

Changeset: 27adbdffd1cf93acd54ec4787b3728ce7df63587

comment:28 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

The pull request for this ticket closed ticket #10833 by mistake.

comment:29 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11722

Note: See TracTickets for help on using tickets.