Context Navigation

← Previous Ticket
Next Ticket →

Ticket #10833 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

CalculateResolution's failure is unhandled by the ISIS Refl Polref UI

Reported by:	Harry Jeffery	Owned by:	Harry Jeffery
Priority:	major	Milestone:	Release 3.4
Component:	GUI	Keywords:
Cc:		Blocked By:
Blocking:		Tester:	Dan Nixon

Description

If CalculateResolution fails, its default value (8.9e+307) is used instead of aborting.

Instead, processing should be aborted.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

Refs #10833 Abort if CalculateResolution fails

Changeset: 97cda828a984b9712fe559dec246b0d5796c53f7

comment:2 Changed 6 years ago by Peter Peterson

Owner set to Harry Jeffery
Status changed from new to assigned

comment:3 Changed 6 years ago by Harry Jeffery

Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Harry Jeffery

Testing

Load OFFSPEC00027585
Open the ISIS Reflectometry (Polref) interface.
Enter OFFSPEC00027585 into the Run(s) column, and 0.35 into the Angle column.
Hit process.
- Processing should fail, with an error message saying to specify dQ/Q manually.

Last edited 6 years ago by Harry Jeffery (previous) (diff)

comment:5 Changed 6 years ago by Harry Jeffery

Status changed from inprogress to verify
Resolution set to fixed

comment:6 Changed 6 years ago by Roman Tolchenov

Status changed from verify to verifying
Tester set to Roman Tolchenov

comment:7 Changed 6 years ago by Roman Tolchenov

Status changed from verifying to reopened
Resolution fixed deleted

Entering 1 into dQ/Q dives another fail message. MantidPlot hangs when you try to close it.

comment:8 Changed 6 years ago by Harry Jeffery

Status changed from reopened to verify
Resolution set to fixed

Ah, that wasn't the best example, as processing OFFSPEC data has other problems, being addressed by #10585.

The scope of this ticket was just to give an informative error message when CalculateResolution fails, as the example demonstrates. I should have explained about the other errors if a value if given. It is odd though that the algorithm is hanging Mantid, and I'll look into that in #10585.

This ticket should still be fine to merge though.

comment:9 Changed 6 years ago by Roman Tolchenov

I cannot see from the description of #10585 how it will address the issue in comment7. Could you please make it clearer?

comment:10 Changed 6 years ago by Harry Jeffery

The processing failure for the OFFSPEC data is due to missing parameters and some components in the IDF being named unusually.

With this in the options column it ought to succeed:

DetectorComponentName="HeDetector", SampleComponentName="sampleholder", MonitorBackgroundWavelengthMin=15, MonitorBackgroundWavelengthMax=20, MonitorIntegrationWavelengthMin=2, MonitorIntegrationWavelengthMax=14, I0MonitorIndex=1, ProcessingInstructions="3"

The tickets have been re-jigged slightly, so the changes to the IDF/parameter files that make those options unnecessary are being introduced in #10658