Ticket #11732 (closed: fixed)
SCARF remote login through web service: fix issues with special characters in passwords
| Reported by: | Federico M Pouzols | Owned by: | Federico M Pouzols |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.5 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Roman Tolchenov |
Description
It seems that there are issues with certain special characters used in user passwords. Clarify and fix if possible with the web service, otherwise some users may not be able to log in using the tomographic reconstruction custom interface.
Change History
comment:2 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from new to inprogress
uri-encode, now the auth script reqs escaped special chars, re #11732
Changeset: 6c0757276d9f99f01fd94aa804676555077a750c
comment:3 Changed 5 years ago by Federico Montesino Pouzols
do a safe pct-encode on login uri components, re #11732
Changeset: c4ef00dcee44a39bdbb003c768d47568bd6c6dc6
comment:4 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #759.
comment:5 Changed 5 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:6 Changed 5 years ago by Roman Tolchenov
A couple of things:
- the camelCase should be used (urlComponentEncode).
- the method should be static.
comment:7 Changed 5 years ago by Federico Montesino Pouzols
use camel case and static-ize urlEncode method, re #11732
Changeset: 50f4f206262a8acba01e863fb81ba13b1fa20d1a
comment:8 Changed 5 years ago by Federico Montesino Pouzols
Oops, thanks for noticing. It should be better now.
comment:9 Changed 5 years ago by Federico Montesino Pouzols
win7-docs-test failed on MDNormDirectSC-v1 because of unrelated issues, but in principle all builds/targets looked happy.
comment:10 Changed 5 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge pull request #759 from mantidproject/11732_scarf_login_scarf_login_token.py_script_special_characters
Handle special characters in passwords - log into SCARF through web service
Full changeset: c811895a3bea12b95aac757cf5d41fa45eb9db3e
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12570
