Ticket #11733 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Implement ChangeTimeZero algorithm for SANS

Reported by: Anton Piccardo-Selg Owned by: Anton Piccardo-Selg
Priority: critical Milestone: Release 3.5
Component: SANS Keywords: sansEvents
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description (last modified by Anton Piccardo-Selg) (diff)

Currently added event data cannot be time sliced, due to the way the PLUS algorithm adds the sample logs.

The first step is to create an algorithm which shifts the timestamps in the logs and if we are dealing with an EventWorkspace also in the neutron timestamps.

Attachments

compare_test.py (4.8 KB) - added by Anton Piccardo-Selg 5 years ago.

Change History

comment:1 Changed 5 years ago by Nick Draper

  • Keywords sansEvents added; SANS removed

comment:2 Changed 5 years ago by Anton Piccardo-Selg

  • Status changed from new to inprogress

Refs #11733 Add validator

Changeset: cb75bb0177c9e1327cb5d163080e0873eda646f0

comment:3 Changed 5 years ago by Anton Piccardo-Selg

  • Description modified (diff)
  • Summary changed from Implement time slicing with added event data in SANS to Implement ChangeTimeZero algorithm for SANS

comment:4 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Change the logs

Changeset: 861e9978d9203059188c00f05bda5ad2f643ff6b

comment:5 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Add unit test setup

Changeset: cccc7390b534e940760006014b65231b3430e865

comment:6 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Alter time for neutrons

Changeset: acddfb2b45dcdbba883b80ee2bf188a9270deb6e

comment:7 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Add more unit tests

Changeset: 1d85dcfe7398ce8ec1034c9aac85b24da7455b9a

comment:8 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Added more validation

Changeset: ce7bd6a4e8992475eeefc5e2fba0cfa88f2bdd01

comment:9 Changed 5 years ago by Anton Piccardo-Selg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #783.

comment:10 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Fix build issues

Changeset: 6677fa019e1d3a6f07d09d65179459b35c8b99bb

comment:11 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Fix doxygen errors

Changeset: 79176c1be1cc40148d9e3755f4202afbdf209e3b

comment:12 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Fix for gcc warning

Changeset: eefa20d688c3f1910b6a9ed80cbadab40abbd133

comment:13 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Fix more doxygen errors

Changeset: ead49e78b22857233b86659a7e186aab6d3555c2

comment:14 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Use separate RelativeTimeS. and AbsoluteTimeS. inputs

Changeset: dc8bbeaba7d15dbf0a8e0e4ecdf7fd2e93432533

Changed 5 years ago by Anton Piccardo-Selg

comment:15 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Change exception type for proton charge

Changeset: dd7a24ccc1abec4d8e6f4dc91af996b5650a1ceb

comment:16 Changed 5 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:17 Changed 5 years ago by Owen Arnold

Missing Restructured Text Documentation help file. Therefore the algorithm has no detailed help, explanations or DocTest.

comment:18 Changed 5 years ago by Owen Arnold

ChangePulseTimes should have progress reporting added as part of this.

comment:19 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 refactoring work on ChangeTimeZero

Changeset: e4377c28dafe22cc775aab5932d1564ead281d3e

comment:20 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Added performance test and documentation to ChangeTimeZero

Changeset: d5b0804a045fc590f0dd59eb6059e4fd3f7bbc6b

comment:21 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Fix compiler warnings

Changeset: 4f95c78c1e533f3628583ac90aadbfc297bf7e8f

comment:22 Changed 5 years ago by Anton Piccardo-Selg

Refs #11733 Fixed ADS bug

Changeset: cc0eaa92ac0e7424deb70d1a6fc5a315f9bb88cf

comment:23 Changed 5 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge pull request #783 from mantidproject/feature/11733_time_slicing_added_event_data_in_SANS

Implement ChangeTimeZero algorithm to shift times in logs and neutron timestamps

Full changeset: a919001a125fa8a088ebb178116e165fb8140a46

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12571

Note: See TracTickets for help on using tickets.