Ticket #2251 (closed: fixed)
The ISIS SANS command LoadSample() should read log values from Nexus
| Reported by: | Steve Williams | Owned by: | Steve Williams |
|---|---|---|---|
| Priority: | major | Milestone: | Iteration 28 |
| Component: | Python | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
LoadSample() (in ISISCommandInterface.py) was failing if a .log file didn't exist. However, if the file to load is a Nexus then a spearate .log file shouldn't be required, the data are in the Nexus file.
Change History
comment:3 Changed 10 years ago by Steve Williams
- Status changed from accepted to verify
- Resolution set to fixed
comment:4 Changed 10 years ago by Steve Williams
- Status changed from verify to reopened
- Resolution fixed deleted
comment:5 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 27 to Iteration 28
Bulk move of tickets at the end of iteration 27
comment:6 Changed 10 years ago by Steve Williams
- Status changed from reopened to verify
- Resolution set to fixed
comment:7 Changed 10 years ago by Steve Williams
It is now possible to do any ISIS SANS analysis on a Nexus or raw file without an associated log file being there.
comment:8 Changed 9 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:9 Changed 9 years ago by Steve Williams
- Status changed from verifying to reopened
- Resolution fixed deleted
comment:11 Changed 9 years ago by Steve Williams
- Status changed from accepted to verify
- Resolution set to fixed
re-opned the wrong ticket
comment:13 Changed 9 years ago by Michael Reuter
- Status changed from verifying to closed
The NeXus files no longer need the log. I ran a reduction with just a sample file and a mask and it work fine.
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 3098
Note: See
TracTickets for help on using
tickets.
Some comments from Richard on this:
The log files were needed when using .raw files for data reduction.
The log files contain positions of the sample detectors etc, so could be edited after an expt. However the mask file allows correction terms to all of these, so I don’t think we should have to edit the original log (which would be unethical anyway?).
If we are only going to use nexus, then we could extract the log information from them ? (But I don’t think this is the default, even for .nxs in SANS data reduction ??)
Richard