Ticket #2412 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Issues with the file finder

Reported by: Brett Tully Owned by: Roman Tolchenov
Priority: blocker Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Archive search not working if file has extension (ie the following call) 

pW = LoadNexus('SANS2D00005512.nxs', 'd').workspace()

however, it works without extension: 

pW = LoadNexus('SANS2D00005512', 'd').workspace()

Yet, secondary calls to load without a file extension give the following error: 

"ValueError on line 9: "Malformed hint to FileFinderImpl::makeFileName: test_file" in file 'mantidsimple.py' at line 6049"

For example: 

pW = LoadNexus('SANS2D00005512', 'd').workspace()
SaveNexus(pW, 'test_file')
LoadNexus('test_file', 'e')

Ask Steve Williams for any clarification needed.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Owner set to Roman Tolchenov
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Nick Draper

  • Priority changed from major to blocker

Also:

From: jon taylor Phone: 07795553415 Comments: file finder no longer finds files on the paths set in manage user directories after rebuild from svn

comment:3 Changed 9 years ago by Roman Tolchenov

  • Status changed from assigned to accepted

comment:4 Changed 9 years ago by Roman Tolchenov

(In [10851]) Hints to FileFinder may contain file extension. re #2412

comment:5 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:7 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Finds the following. Works with extension, i.e.:

pW = LoadNexus('argus0026287.nxs', 'd').workspace()

but now not without extension, i.e.:

pW = LoadNexus('argus0026287', 'd').workspace()

comment:8 Changed 9 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:9 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

The issue is with the argus files which have zeropadding = 8 in Facilities.xml but the files we are testing against have only 7 digits. This issue should be handled in a separate ticket.

comment:10 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester changed from Anders Markvardsen to Martyn Gigg

comment:11 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified in 11162. Tried various combinations of filenames with/without instrument names and different zero paddings. With the already noted exception for Argus this looks fine.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3259

Note: See TracTickets for help on using tickets.