Ticket #2785 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

SANS: Getting masking 'MASK Vn>Vm+Hn>Hm' to work

Reported by: Steve Williams Owned by: Anders Markvardsen
Priority: critical Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

MASK H51>H57+V132>V138 works, but the opposite way around MASK V132>V138+H51>H57 takes out rows 51 to 57, not the box.

First implement raising an error if (as above) V is set before H Then document what is meant to happen get it working write tests

Attachments

mask_temp.txt (1.8 KB) - added by Anders Markvardsen 9 years ago.
user file
directM1_9672_6m_08Aug11.DAT (8.0 KB) - added by Anders Markvardsen 9 years ago.
File required to be in the same directory as the user file

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:3 Changed 9 years ago by Anders Markvardsen

  • Status changed from new to assigned
  • Owner changed from Steve Williams to Anders Markvardsen

Note e.g. H56 reads horenzontal 56.

It does not work for the front detector on LOQ (but it likely never need to)

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:5 Changed 9 years ago by Anders Markvardsen

  • Summary changed from Getting box masks working reliably to SANS: Getting box masks working reliably

comment:6 Changed 9 years ago by Anders Markvardsen

  • Priority changed from major to critical

comment:7 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:8 Changed 9 years ago by Anders Markvardsen

  • Summary changed from SANS: Getting box masks working reliably to SANS: Getting masking 'MASK Vn>Vm+Hn>Hm' to work

comment:9 Changed 9 years ago by Anders Markvardsen

SANS: now masking type 'mask v134>v141+h57>h66' works. re #2785

Changeset: 5e7aff8553e35244772c9388f09a655d9b23c5f4

Changed 9 years ago by Anders Markvardsen

user file

Changed 9 years ago by Anders Markvardsen

File required to be in the same directory as the user file

comment:10 Changed 9 years ago by Anders Markvardsen

  • Status changed from assigned to accepted

To test save attached file to same directory. Load user file in isis sans gui. User file contains line of type mask v134>v141+h57>h66. Modify this line if you like. Hit the display mask button and you should see a rectangular area masked out.

comment:11 Changed 9 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:13 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

When I try to display the mask, MantidPlot crashes on RHEL6 and OSX. On Windows, the script completes, but I don't see any display.

comment:14 Changed 8 years ago by Anders Markvardsen

Replace _qti with mantidplot python import. re #2785

Changeset: d4e420ff327906ade08cd75bff27fc52f1bd8432

comment:15 Changed 8 years ago by Anders Markvardsen

  • Status changed from reopened to accepted

comment:16 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:17 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:18 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

The display now works and I can see the masked area.

comment:19 Changed 8 years ago by Anders Markvardsen

Replace _qti with mantidplot python import. re #2785

Changeset: d4e420ff327906ade08cd75bff27fc52f1bd8432

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3632

Note: See TracTickets for help on using tickets.