Ticket #2948 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

MantidPlot Algorithm GUI: Only show workspaces of the right type in list

Reported by: Janik Zikovsky Owned by: Martyn Gigg
Priority: major Milestone: Iteration 30
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

If a WorkspaceProperty is of type GroupingWorkspace, for example, it should ONLY show the workspaces compatible with that type. Currently, it shows all workspaces.

For example, see the GroupingWorkspace property of DiffractionFocussing2.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:2 Changed 9 years ago by Nick Draper

  • Owner set to Martyn Gigg
  • Status changed from new to assigned

attempt to assign each workspace to the algorithm property in turn, and only put them in the list is no exception is thrown

comment:3 Changed 9 years ago by Martyn Gigg

  • Status changed from assigned to verify
  • Resolution set to fixed

In [14729]:

Fix allowedValues on WorkspaceProperty to only return those of the correct type. Fixes #2948

comment:4 Changed 9 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:5 Changed 9 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The filter seems to let through all workspace groups. Try loading a group say from musr00015189 and run SaveMD. The dialog shows the group ws name but the algorithm fails.

comment:6 Changed 9 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:7 Changed 9 years ago by Martyn Gigg

The code in WorkspaceProperty will need a big of rejigging in terms of the isValid member to do this effectively.

This is a core class and it would be better for these changes to bed in to ensure edge cases are not missed. A new ticket has been created for the next iteration: #3761

comment:8 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Apart from the groups, it works though.

comment:9 Changed 9 years ago by Roman Tolchenov

  • Status changed from verify to verifying

comment:10 Changed 9 years ago by Roman Tolchenov

  • Status changed from verifying to closed

It works indeed.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3795

Note: See TracTickets for help on using tickets.