Ticket #3145 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Mostly trivial changes to Indirect scripts

Reported by: Michael Whitty Owned by:
Priority: minor Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description


Change History

comment:1 Changed 9 years ago by Michael Whitty

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Michael Whitty

(In [12349]) refs #3145 - revert indirect reducer to using LoadRaw rather than Load because it conflicts with how Timmy works and these instruments won't be moving onto Nexus anytime soon. made a change to how a parameter file in reducer so that it doesn't try and search for it in the datasearch.directories, which can take a long time on network drives.

comment:3 Changed 9 years ago by Michael Whitty

(In [12438]) refs #3145 - stop annoying message originating in CTE ui if another interface selects an incompatible instrument. change inelastic_indirect_reducer to use new MSGReducer base to prevent code duplication between diffraction & spectroscopy workflows for these instruments.

comment:4 Changed 9 years ago by Michael Whitty

(In [12468]) refs #3145 - some tidyup of reducer scripts for indirect, checking in incremental changes before I break something

comment:5 Changed 9 years ago by Michael Whitty

(In [12469]) refs #3145 - add option to hold off on summing multiple frames in TOSCA reduction, with checkbox on the interface, refs #3016 - diffraction data in IRIS and TOSCA will now be grouped into a single spectra, fixes #3047 - adjusted work around to allow for changing of binning parameters.

comment:6 Changed 9 years ago by Michael Whitty

(In [12499]) refs #3145 - update reference result for tosca reduction system test. difference is insignificant.

comment:7 Changed 9 years ago by Michael Whitty

being more exact: difference in system test reference result was due to moving where the IdentifyNoisyDetectors algorithm is called in the reducer to allow for use in the diffraction reducer. This move caused one of the less friendly detectors, which had previously been deemed allowable, to be marked as crap. This is reasonable - though if Timmy remarks that his results are slightly different now to OpenGENIE, this is the reason.

comment:8 Changed 9 years ago by Nick Draper

  • Owner Michael Whitty deleted

Moved from Michael Whitty

comment:9 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:10 Changed 9 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:12 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

Hard to verify this objectively, but parsing through the changelogs seems to match up with the requests.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3992

Note: See TracTickets for help on using tickets.