Ticket #3146 (closed)

Opened 9 years ago

Last modified 5 years ago

EQSANS: protect against files loaded outside the reduction process

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

Keep track of workspaces loaded by the reduction process so the user is notified if a workspace already exists with the same name as one we intend to create.

Change History

comment:1 Changed 9 years ago by Mathieu Doucet

  • Status changed from new to verify
  • Resolution set to fixed

(In [12358]) Fixes #3146

comment:2 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:3 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I loaded a EQSANS_1466_event.nxs into "1466_evt" and used the GUI to load that run number and the workspace was overwritten.

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

moved to iteration 30.

This appears to only occur if the user is actually trying something a bit silly, rather than by pure accident.

comment:5 Changed 9 years ago by Mathieu Doucet

  • Status changed from reopened to accepted

comment:6 Changed 9 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to wontfix

Since that ticket was created the logic has changed a little and the chances of the problem happening is very tiny. You'd have to load the file, reduce it using the Reducer framework, then try to reduce it again with the GUI. That mostly happens when someone is fiddling with the reduction, or when a developer is testing the code.

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying

comment:8 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

Sounds fine to me :)

comment:9 Changed 9 years ago by Nick Draper

  • Status changed from closed to verify
  • Resolution wontfix deleted

Corrected status to verify

comment:10 Changed 9 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester changed from Janik Zikovsky to Peter Peterson

comment:11 Changed 9 years ago by Peter Peterson

  • Status changed from verifying to closed

Since the fix is four months old and the ticket hasn't been reopened...

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3993

Note: See TracTickets for help on using tickets.