[IndDiff] - Input Validation / Wiki Instructions / General Check

[Peter Parker]

From Spencer:

IRIS data for diffspec option.

The d-spacing option is confusing in that the instructions state:

Rebin (mandatory for IRIS) - specify parameters for the Rebin algorithm, to be applied in dSpacing. You may leave these fields blank to forego rebinning.

"Mandatory for IRIS" is inconsistent with leaving fields blank isn't it?

I left them blank and got

ValueError: Invalid value for property InputWorkspace (MatrixWorkspace) "irs26176": The workspace must have common bin boundaries for all histograms at line 12 in '<Interface>'
caused by line 494 in 'C:/MantidInstall/scripts\reduction\reducer.py'
caused by line 763 in 'C:/MantidInstall/scripts/Inelastic\inelastic_indirect_reduction_steps.py'
caused by line 842 in 'C:/MantidInstall/scripts/Inelastic\inelastic_indirect_reduction_steps.py'
caused by line 41 in 'C:/MantidInstall/bin\mantidsimple.py'
caused by line 1071 in 'C:/MantidInstall/bin\MantidFramework.py'
caused by line 1046 in 'C:/MantidInstall/bin\MantidFramework.py'

We need to ensure that the input validation is as robust for IRIS/TOSCA as it is for OSIRIS, and that the wiki is correct and up-to-date.

[Peter Parker]

Refs #5566 - Fix bug in case where user only inputs one run (OSIRIS).

Also, raise exceptions where we were previously reporting to log and calling sys.exit().

Changeset: 1bd46c7231fd2fb600ee0839d6d060c40744e45d

[Peter Parker]

Refs #5566 - Fix bug in case where user only inputs one run (OSIRIS).

Also, raise exceptions where we were previously reporting to log and calling sys.exit().

Changeset: 1bd46c7231fd2fb600ee0839d6d060c40744e45d

[Nick Draper]

Moved at the end of release 2.2

[Peter Parker]

Update:

Under the guidance of Franz Demmel (OSIRIS instrument scientist at ISIS) earlier in the year, I overhauled the OSIRIS section of the Indirect Diffraction interface.

As part of this work, the input validation and underlying Python code became a lot more robust / stable, resulting in far fewer errors, etc. I also updated the Wiki to better represent the functionality offered.

To proceed on this ticket, and to get the parts up to a similar standard, I feel that getting a better understanding of the underlying code for IRIS/TOSCA is crucial. Spencer's comment about the d-spacing is valid and should addressed.

[Nick Draper]

Moved to milestone 2.4

[Nick Draper]

Moved at the code freeze for release 2.4

[Nick Draper]

Moved to r2.6 at the end of r2.5

[Nick Draper]

Moved to backlog at the code freeze for R2.6

[Nick Draper]

Bulk move to assigned at the introduction of the triage step

[Dan Nixon]

I've tested the rebinning option with IRIS and found it to work both when providing options and leaving blank, so have removed the mandatory note from the Wiki.

I agree that the diffraction interface could do with being cleaned up (both UI and IRIS/TOSCA algorithm) and have opened a ticket for that (#10215).

[Dan Nixon]

I've opened another ticket for the refactoring (#10215).

The worksforme resolutions is due to the fact I can perform a diffration reduction with IRIS data without rebinning and do not get the error.

[Stuart Campbell]

This ticket has been transferred to github issue ​6412