Ticket #5567 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Modify MERLIN illiad with absolute normalization to produce results equvalent to LIBISIS

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.0
Component: Direct Inelastic Keywords:
Cc: Blocked By: #6230
Blocking: Tester: Martyn Gigg

Description


Attachments

LibisisVSManitd.pdf (370.4 KB) - added by Alex Buts 8 years ago.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Alex Buts

There is no description here, so is this an investigation ticket, or a fix of an understood problem?

Changed 8 years ago by Alex Buts

comment:2 Changed 8 years ago by Alex Buts

At the moment, from the same experiment data, Mantid produces results which differ from initially produced by Libisis, so the Merlin scientists continue using Libisis. The differences are roughly highlighted by the file attached.

The Mantid results are produced on the basis of algorithms, python algorithms and custom python scripts, with various settings affecting results on various steps, so the task may be reformulated as creation of number of unit(or system) tests, which walk through all these steps and compare results with some agreed basis results.

Initial ticket without description came to be able properly commit some initial changes to the user script directory. These changes are seems not attached to Track.

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:4 Changed 8 years ago by Alex Buts

refs #5567 Modified dgreduce which do not crashes on 0 spectra

but print diagnostics if found one wrong.

Changeset: 88458211010b2299cdd14cd0c30b345827724908

comment:5 Changed 8 years ago by Alex Buts

refs #5567 fixing system test

Changeset: 8695a0de09d5aba6fa75d9e82502047ce36b7322

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:7 Changed 8 years ago by Alex Buts

  • Blocked By 6230 added

comment:8 Changed 8 years ago by Alex Buts

  • Milestone changed from Release 2.4 to Release 2.5

comment:9 Changed 8 years ago by Alex Buts

refs #5567 Preparing to allow different monitor Num in reduction

Changeset: 4b839098c2623a82f3f8da1795673db37ae9d49d

comment:10 Changed 7 years ago by Alex Buts

  • Milestone changed from Release 2.5 to Release 2.6

comment:11 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:12 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:13 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:14 Changed 7 years ago by Alex Buts

  • Milestone changed from Backlog to Release 3.0

comment:15 Changed 7 years ago by Alex Buts

  • Status changed from new to verify
  • Resolution set to fixed

The sample script for merlin reduction has been added to the script repository https://github.com/mantidproject/scriptrepository/blob/master/direct_inelastic/MERLIN/mantid_iliad_abs_sample.py and tested against results, produced by Libisis.

The results coincide and Merlin now uses Mantid for reduction.

Nothing to test here -- no changes to the code were necessary after 6230

comment:16 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:17 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

It would appear everything is already on master so nothing to test.

comment:18 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Direct Inelastic

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6413

Note: See TracTickets for help on using tickets.