Ticket #6812 (closed: fixed)
GeneratePythonScript is broken for Load algorithm
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 2.5 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Russell Taylor |
Description
After fixing #5885 it appears that the unit tests didn't pick up that GeneratePythonScript doesn't work with properties that don't exist on the standard algorithm call. This is now broken in master and needs fixing!
Change History
comment:2 Changed 8 years ago by Martyn Gigg
Fix GeneratePythonScript for Load algorithm Refs #6812
It does not currently handle properties that don't exist when the algorithm is initialized very well.
Changeset: 73d6288bc527c9f344de92a83a93153d317a4c52
comment:4 Changed 8 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
Branch: bugfix/6812_fix_generatepythonscript
Tester: Certain algorithms, Load & Fit, have some properties that get dynamically. Check that setting these extra properties, i.e Precount for Load with an event nexus file or SpectrumMax for a raw file allows a python script to be generated.
comment:5 Changed 8 years ago by Martyn Gigg
Put back file removal. Refs #6812
Changeset: 673de16aad90c2eba0c0b6f64519f883690dfb8a
comment:6 Changed 8 years ago by Martyn Gigg
Put back file removal. Refs #6812
Changeset: 673de16aad90c2eba0c0b6f64519f883690dfb8a
comment:7 Changed 8 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:8 Changed 8 years ago by Martyn Gigg
Fix GeneratePythonScript for Load algorithm Refs #6812
It does not currently handle properties that don't exist when the algorithm is initialized very well.
Changeset: 73d6288bc527c9f344de92a83a93153d317a4c52
comment:9 Changed 8 years ago by Martyn Gigg
Put back file removal. Refs #6812
Changeset: 673de16aad90c2eba0c0b6f64519f883690dfb8a
comment:10 Changed 8 years ago by Russell Taylor
- Status changed from verifying to closed
The system test is passing now (https://builds.sns.gov/job/ornl_test_rhel6_develop/) and script generation worked for both a raw & event nexus file.
comment:11 Changed 8 years ago by Martyn Gigg
Fix GeneratePythonScript for Load algorithm Refs #6812
It does not currently handle properties that don't exist when the algorithm is initialized very well.
Changeset: 73d6288bc527c9f344de92a83a93153d317a4c52
comment:12 Changed 8 years ago by Martyn Gigg
Put back file removal. Refs #6812
Changeset: 673de16aad90c2eba0c0b6f64519f883690dfb8a
comment:13 Changed 7 years ago by Martyn Gigg
Fix GeneratePythonScript for Load algorithm Refs #6812
It does not currently handle properties that don't exist when the algorithm is initialized very well.
Changeset: 73d6288bc527c9f344de92a83a93153d317a4c52
comment:14 Changed 7 years ago by Martyn Gigg
Put back file removal. Refs #6812
Changeset: 673de16aad90c2eba0c0b6f64519f883690dfb8a
comment:15 Changed 7 years ago by Martyn Gigg
Fix GeneratePythonScript for Load algorithm Refs #6812
It does not currently handle properties that don't exist when the algorithm is initialized very well.
Changeset: 73d6288bc527c9f344de92a83a93153d317a4c52
comment:16 Changed 7 years ago by Martyn Gigg
Put back file removal. Refs #6812
Changeset: 673de16aad90c2eba0c0b6f64519f883690dfb8a
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7658
Fix GeneratePythonScript for Load algorithm Refs #6812
It does not currently handle properties that don't exist when the algorithm is initialized very well.